From: Junio C Hamano <gitster@pobox.com>
To: Pascal Obry <pascal.obry@wanadoo.fr>
Cc: git list <git@vger.kernel.org>
Subject: Re: [PATCH] Use --no-color option on git log commands.
Date: Tue, 27 Nov 2007 20:45:02 -0800 [thread overview]
Message-ID: <7vr6ib9dwx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <474C60FA.4040302@wanadoo.fr> (Pascal Obry's message of "Tue, 27 Nov 2007 19:24:58 +0100")
Pascal Obry <pascal.obry@wanadoo.fr> writes:
> Junio C Hamano a écrit :
>> The patch is good as belt-and-suspender, thanks.
>
> Ok.
>
>> But I suspect that we should make 'true' to mean 'auto' someday in
>> git_config_colorbool(). Crazy people can set 'always' if they really
>> wanted to, but most normal people would not want color unless the output
>> goes to the terminal, I would think.
>
> I definitely agree. I add it set to true, using auto instead I do not
> have the problem. Anyway I still think that it is good to apply my patch
> to completely avoid such issues.
Yes, that is what I said.
Except that the patch is severely whitespace damaged, and the message
lack a sign-off.
I fixed them up by hand, so no need to resend.
next prev parent reply other threads:[~2007-11-28 11:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 22:04 [PATCH] Use --no-color option on git log commands Pascal Obry
2007-11-26 22:30 ` Junio C Hamano
2007-11-27 18:24 ` Pascal Obry
2007-11-28 4:45 ` Junio C Hamano [this message]
2007-11-28 7:26 ` [PATCH/RFC] "color.diff = true" is not "always" anymore Junio C Hamano
2007-11-28 13:13 ` Johannes Schindelin
2007-11-28 19:04 ` Jeff King
2007-12-01 2:36 ` Junio C Hamano
2007-12-01 4:15 ` Jeff King
2007-12-01 6:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6ib9dwx.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pascal.obry@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.