All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Francis Daly <francis@daoine.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-quiltimport /bin/sh-ism fix
Date: Thu, 29 Mar 2007 16:06:03 -0700	[thread overview]
Message-ID: <7vr6r71wh0.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070329213820.GY24561@craic.sysops.org> (Francis Daly's message of "Thu, 29 Mar 2007 22:38:20 +0100")

Francis Daly <francis@daoine.org> writes:

> Bryan Wu reported
> /usr/local/bin/git-quiltimport: 114: Syntax error: Missing '))'
>
> Most bourne-ish shells I have here accept
>  x=$((echo x)|cat)
> but all bourne-ish shells I have here accept
>  x=$( (echo x)|cat)
> because $(( might mean arithmetic expansion.

Well spotted, thanks.


Sheesh, this is even warned in POSIX sh manpage.

  reply	other threads:[~2007-03-29 23:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-29 21:38 [PATCH] git-quiltimport /bin/sh-ism fix Francis Daly
2007-03-29 23:06 ` Junio C Hamano [this message]
2007-03-30  2:05 ` Wu, Bryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr6r71wh0.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=francis@daoine.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.