All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Martin Langhoff <martin.langhoff@gmail.com>,
	Chris Shoemaker <c.shoemaker@cox.net>,
	git@vger.kernel.org
Subject: Re: [PATCH gitweb] Visually indicating patch size with horizontal bars
Date: Thu, 27 Oct 2005 20:52:07 -0700	[thread overview]
Message-ID: <7vr7a6z4bc.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0510271933140.4664@g5.osdl.org> (Linus Torvalds's message of "Thu, 27 Oct 2005 19:38:21 -0700 (PDT)")

Linus Torvalds <torvalds@osdl.org> writes:

> Well, if you do full copy detection (and break detection), then 
> git-diff-tree will actually have effectively calculated the size of the 
> diff of each file. It just doesn't print them (well, it does a percentage 
> for the renames/copies).

Unbroken in-place edit would never go through diffcore-rename,
so that is a gross overstatement.

But we could if we wanted to.  I do not know how useful it would
be, but if somebody wants to do it, I think the best strategy is
to do as a separate diffcore backend that comes after
diffcore_rename() runs, and do the similarity estimator only on
filepairs that rename/copy did not touch.

  reply	other threads:[~2005-10-28  3:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-27 20:39 [PATCH gitweb] Visually indicating patch size with horizontal bars Chris Shoemaker
2005-10-27 22:02 ` Junio C Hamano
2005-10-27 23:48   ` Chris Shoemaker
2005-10-28  0:12     ` Linus Torvalds
2005-10-28  0:50       ` Chris Shoemaker
2005-10-28  1:08         ` Martin Langhoff
2005-10-28  1:13         ` H. Peter Anvin
2005-10-28  8:29           ` Andreas Ericsson
2005-10-28  9:31         ` Junio C Hamano
2005-10-28  1:16   ` Martin Langhoff
2005-10-28  2:38     ` Linus Torvalds
2005-10-28  3:52       ` Junio C Hamano [this message]
2005-10-28 16:02         ` Linus Torvalds
2005-10-28  1:56 ` Kay Sievers
2005-10-28  2:38   ` Chris Shoemaker
2005-11-01 23:30     ` Petr Baudis
2005-11-01 23:33       ` Martin Langhoff
2005-11-01 23:43         ` Petr Baudis
2005-11-02  8:08           ` Andreas Ericsson
2005-11-02 10:37             ` Johannes Schindelin
2005-11-02 12:19               ` Andreas Ericsson
2005-11-02 12:43                 ` Johannes Schindelin
2005-11-02  0:12         ` Chris Shoemaker
2005-11-02  0:26           ` Kay Sievers
2005-12-05  0:04           ` Petr Baudis
2005-12-05  1:03             ` Chris Shoemaker
2005-10-28  9:16 ` Josef Weidendorfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr7a6z4bc.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=c.shoemaker@cox.net \
    --cc=git@vger.kernel.org \
    --cc=martin.langhoff@gmail.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.