All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
	"git\@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: t3010 broken by 2eac2a4
Date: Thu, 22 Aug 2013 22:36:46 -0700	[thread overview]
Message-ID: <7vsiy1j7dd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAPig+cR0Z0gghUH5C6+XCuGQ3gz5JoWrnObVbbA5_ahPmC8G2Q@mail.gmail.com> (Eric Sunshine's message of "Fri, 23 Aug 2013 00:32:26 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

> I sent a patch [1] which resolves the problem, although the solution
> is not especially pretty (due to some ugliness in the existing
> implementation).

Yeah, thanks.

I tend to agree with you that fixing the "icase" callee not to rely
on having the trailing slash (which is looking past the end of the
given string), instead of working that breakage around on the
caller's side like your patch did, would be a better alternative,
though.

  reply	other threads:[~2013-08-23  5:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 20:31 t3010 broken by 2eac2a4 Brian Gernhardt
2013-08-21 21:41 ` Junio C Hamano
2013-08-22 20:54   ` Eric Sunshine
2013-08-22 21:16     ` Junio C Hamano
2013-08-22 21:22       ` Eric Sunshine
2013-08-22 21:32         ` Junio C Hamano
2013-08-22 21:35           ` Eric Sunshine
2013-08-22 21:43             ` Junio C Hamano
2013-08-22 21:59               ` Eric Sunshine
2013-08-22 22:53                 ` Eric Sunshine
2013-08-22 23:12                   ` Junio C Hamano
2013-08-22 23:15                     ` Eric Sunshine
2013-08-23  4:32                       ` Eric Sunshine
2013-08-23  5:36                         ` Junio C Hamano [this message]
2013-08-23  9:19                           ` Eric Sunshine
2013-08-23 17:15                             ` Junio C Hamano
2013-08-23 18:51                               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsiy1j7dd.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=brian@gernhardtsoftware.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.