All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: mhagger@alum.mit.edu
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Jakub Narebski <jnareb@gmail.com>,
	Heiko Voigt <hvoigt@hvoigt.net>,
	Johan Herland <johan@herland.net>
Subject: Re: [PATCH 1/7] t5700: document a failure of alternates to affect fetch
Date: Sun, 12 Feb 2012 19:35:19 -0800	[thread overview]
Message-ID: <7vsjifids5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 1328941261-29746-2-git-send-email-mhagger@alum.mit.edu

mhagger@alum.mit.edu writes:

> +test_expect_success 'prepare branched repository' '
> +	git clone A J &&
> +	(
> +		cd J &&
> +		git checkout -b other master^ &&
> +		echo other > otherfile &&

s/ > / >/; but that is nothing I cannot fix locally.

> +test_expect_failure 'fetch with incomplete alternates' '

I am assuming that this "incomplete" means "this alternate helps reducing
the number of objects we need to fetch from the remote, but it does not
have everything objects we need, and we still need to fetch some from the
remote".  Am I correct?

I do not think you meant the alternate repository is in some way corrupt,
but I am just making sure, because I found the phrasing a bit odd.

  reply	other threads:[~2012-02-13  4:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-11  6:20 [PATCH 0/7] Make alternates affect fetch behavior mhagger
2012-02-11  6:20 ` [PATCH 1/7] t5700: document a failure of alternates to affect fetch mhagger
2012-02-13  3:35   ` Junio C Hamano [this message]
2012-02-13  4:45     ` Michael Haggerty
2012-02-11  6:20 ` [PATCH 2/7] clone.c: move more code into the "if (refs)" conditional mhagger
2012-02-13  3:35   ` Junio C Hamano
2012-02-11  6:20 ` [PATCH 3/7] fetch-pack.c: rename some parameters from "path" to "refname" mhagger
2012-02-13  3:47   ` Junio C Hamano
2012-02-11  6:20 ` [PATCH 4/7] fetch-pack.c: inline insert_alternate_refs() mhagger
2012-02-11  6:20 ` [PATCH 5/7] everything_local(): mark alternate refs as complete mhagger
2012-02-11  6:21 ` [PATCH 6/7] clone: do not add alternate references to extra_refs mhagger
2012-02-13  4:00   ` Junio C Hamano
2012-02-11  6:21 ` [PATCH 7/7] refs: remove the extra_refs API mhagger
2012-02-14 22:51 ` [PATCH 0/7] Make alternates affect fetch behavior Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsjifids5.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    --cc=jnareb@gmail.com \
    --cc=johan@herland.net \
    --cc=mhagger@alum.mit.edu \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.