From: Junio C Hamano <gitster@pobox.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, git@vger.kernel.org
Subject: Re: [PATCHv2] Add --reference option to git submodule.
Date: Tue, 28 Apr 2009 11:52:09 -0700 [thread overview]
Message-ID: <7vskjslig6.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <49F702C0.8030206@drmicha.warpmail.net> (Michael J. Gruber's message of "Tue, 28 Apr 2009 15:21:04 +0200")
Michael J Gruber <git@drmicha.warpmail.net> writes:
> Michael S. Tsirkin venit, vidit, dixit 28.04.2009 14:30:
>> This adds --reference option to git submodule add and
>> git submodule update commands, which is passed on to git clone.
>>
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>>
>> Here's v2. Ack?
>
> I don't think it's up to me to Ack but you addressed my remarks.
You can certainly say "Reviewed-by: me" and/or "Tested-by: me".
> BTW, even dash has "test STRING" so portability doesn't require -n but I
> think it's OK either way.
It always is a good discipline and style.
next prev parent reply other threads:[~2009-04-28 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 12:30 [PATCHv2] Add --reference option to git submodule Michael S. Tsirkin
2009-04-28 13:21 ` Michael J Gruber
2009-04-28 14:51 ` Johannes Sixt
2009-04-28 17:01 ` Michael J Gruber
2009-04-28 18:52 ` Junio C Hamano [this message]
2009-05-04 17:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskjslig6.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.