From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: Jeff King <peff@peff.net>, David Abrahams <dave@boostpro.com>,
git@vger.kernel.org
Subject: Re: git diff bug?
Date: Mon, 06 Apr 2009 10:56:41 -0700 [thread overview]
Message-ID: <7vskkl64yu.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <vpqeiw53cpy.fsf@bauges.imag.fr> (Matthieu Moy's message of "Mon, 06 Apr 2009 19:37:29 +0200")
Matthieu Moy <Matthieu.Moy@imag.fr> writes:
> Jeff King <peff@peff.net> writes:
>
>> But the latter two lines are about preference: "here is how _I_ would
>> like to generate diffs for el files".
>
> ... and they are commands to be executed. If they were in the
> repository, and propagated with clone, then doing
>
> git clone git://some.git/repo
> cd repo
> git diff
>
> would execute arbitrary commands, which wouldn't be acceptable for
> security reasons.
Other configuration variables have such security implications, but diff
hunk header bit doesn't. You are a bit overly cautious in this particular
case.
next prev parent reply other threads:[~2009-04-06 17:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-04 1:10 git diff bug? David Abrahams
2009-04-04 1:45 ` Jeff King
2009-04-04 1:52 ` Jeff King
2009-04-06 9:09 ` David Abrahams
2009-04-06 14:44 ` Michael J Gruber
2009-04-06 17:58 ` David Abrahams
2009-04-06 18:48 ` Jeff King
2009-04-06 15:53 ` Jeff King
2009-04-06 17:37 ` Matthieu Moy
2009-04-06 17:56 ` Junio C Hamano [this message]
2009-04-06 19:32 ` Matthieu Moy
2009-04-06 18:16 ` David Abrahams
2009-04-07 18:25 ` Antriksh Pany
-- strict thread matches above, loose matches on Subject: below --
2013-06-06 21:26 Sarma Tangirala
2013-06-06 21:42 ` Célestin Matte
2013-06-06 22:17 ` Junio C Hamano
2013-06-07 16:01 ` Sarma Tangirala
2013-06-10 12:44 ` Célestin Matte
2013-06-10 14:41 ` Sarma Tangirala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskkl64yu.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=dave@boostpro.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.