All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nazri Ramliy <ayiehere@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Bugfix: GIT_EXTERNAL_DIFF with more than one changed files
Date: Thu, 12 Feb 2009 12:43:42 -0800	[thread overview]
Message-ID: <7vskmjl729.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090212140740.GB3057@coredump.intra.peff.net

Jeff King <peff@peff.net> writes:

> So this bug should trigger only in the face of reusing worktree files. I
> checked your test; it constructs a diff between the worktree and the
> index, so it correctly finds the problem.
>
> Acked-by: Jeff King <peff@peff.net>

Thanks, both.

Jeff, according to your analysis, this shouldn't trigger when
core.autocrlf is set, should it?

  reply	other threads:[~2009-02-12 20:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 13:36 [PATCH] Bugfix: GIT_EXTERNAL_DIFF with more than one changed files Nazri Ramliy
2009-02-12 14:07 ` Jeff King
2009-02-12 20:43   ` Junio C Hamano [this message]
2009-02-13 18:07     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vskmjl729.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=ayiehere@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.