All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] pack-objects: Fix compilation with NO_PTHREDS
Date: Sat, 25 Feb 2012 01:02:42 -0800	[thread overview]
Message-ID: <7vty2fffpp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1330157769-7884-1-git-send-email-michal.kiedrowicz@gmail.com> ("Michał Kiedrowicz"'s message of "Sat, 25 Feb 2012 09:16:09 +0100")

Michał Kiedrowicz <michal.kiedrowicz@gmail.com> writes:

> It looks like commit 99fb6e04 (pack-objects: convert to use
> parse_options(), 2012-02-01) moved the #ifdef NO_PTHREDS around but
> hasn't noticed that the 'arg' variable no longer is available.
>
> Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com>

Thanks.  Nguyễn, a quick double-check and an Ack?

> ---
>  builtin/pack-objects.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index db09cf7..71af246 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -2449,7 +2449,7 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
>  		die("bad pack compression level %d", pack_compression_level);
>  #ifdef NO_PTHREADS
>  	if (delta_search_threads != 1)
> -		warning("no threads support, ignoring %s", arg);
> +		warning("no threads support, ignoring --threads");
>  #endif
>  	if (!pack_to_stdout && !pack_size_limit)
>  		pack_size_limit = pack_size_limit_cfg;

  reply	other threads:[~2012-02-25  9:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25  8:16 [PATCH] pack-objects: Fix compilation with NO_PTHREDS Michał Kiedrowicz
2012-02-25  9:02 ` Junio C Hamano [this message]
2012-02-25  9:24   ` Nguyen Thai Ngoc Duy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vty2fffpp.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=michal.kiedrowicz@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.