From: Junio C Hamano <gitster@pobox.com>
To: Peter Oberndorfer <kumbayo84@arcor.de>
Cc: git@vger.kernel.org, Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: Reference has invalid format: check maybe a bit to harsh?
Date: Mon, 31 Oct 2011 12:54:31 -0700 [thread overview]
Message-ID: <7vty6pos20.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <60007404.ge1WXNp2Qn@soybean> (Peter Oberndorfer's message of "Mon, 31 Oct 2011 20:14:25 +0100")
Peter Oberndorfer <kumbayo84@arcor.de> writes:
> The invalid refs(about 30, loose and packed) containing a ':' were created by
> stgit a long time ago(Dec 2006)
I think even back then colon was one of the forbidden letters in a
refname. Of course, it is entirely possible that broken third-party tools
may have created such file that is not a ref in .git/refs hierarchy by
hand, and we may not be carefully rejecting such broken refs for a long
time.
... Goes and asks "git blame" ...
03feddd (git-check-ref-format: reject funny ref names., 2005-10-13)
started disallowing control characters and other characters that are used
for range operators and the separator between LHS and RHS of refspecs,
further tightened by 6828399 (Forbid pattern maching characters in
refnames., 2005-12-15).
> But i'm just wondering if dieing when seeing a single invalid ref might be a
> bit too harsh since no git tools can be used anymore on this repo at all.
I agree that we would want to give users an escape hatch. That is, if we
can make something like this to work:
c=$(git rev-parse --force refs/patches/obd_development/blah:_vari...)
git update-ref refs/patches/obd_development/blah--various-improvements $c
I think we would be in a good shape.
next prev parent reply other threads:[~2011-10-31 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 19:14 Reference has invalid format: check maybe a bit to harsh? Peter Oberndorfer
2011-10-31 19:54 ` Junio C Hamano [this message]
2011-10-31 20:19 ` Junio C Hamano
2011-11-01 9:59 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vty6pos20.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kumbayo84@arcor.de \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.