From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Christian Couder <christian.couder@gmail.com>,
Jens Lehmann <Jens.Lehmann@web.de>,
git@vger.kernel.org
Subject: Re: [PATCH 7/7] run_hook: use argv_array API
Date: Wed, 14 Sep 2011 11:54:11 -0700 [thread overview]
Message-ID: <7vty8ft0oc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110913215824.GG24490@sigill.intra.peff.net> (Jeff King's message of "Tue, 13 Sep 2011 17:58:25 -0400")
Jeff King <peff@peff.net> writes:
> @@ -609,26 +610,23 @@ int finish_async(struct async *async)
> int run_hook(const char *index_file, const char *name, ...)
> {
> struct child_process hook;
> - const char **argv = NULL, *env[2];
> + struct argv_array argv = ARGV_ARRAY_INIT;
> + const char *p, *env[2];
Given that in argv-array.h you define it as
#define ARGV_ARRAY_INIT { empty_argv, 0, 0 };
the above will introduce decl-after-stmt.
next prev parent reply other threads:[~2011-09-14 18:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 21:50 [PATCH 0/7] create argv_array API Jeff King
2011-09-13 21:57 ` [PATCH 1/7] add sha1_array API docs Jeff King
2011-09-13 21:57 ` [PATCH 2/7] quote.h: fix bogus comment Jeff King
2011-09-13 21:57 ` [PATCH 3/7] refactor argv_array into generic code Jeff King
2011-09-14 5:54 ` Christian Couder
2011-09-14 23:18 ` Jeff King
2011-09-14 18:42 ` Junio C Hamano
2011-09-14 18:51 ` Junio C Hamano
2011-09-13 21:58 ` [PATCH 4/7] quote: provide sq_dequote_to_argv_array Jeff King
2011-09-13 21:58 ` [PATCH 5/7] bisect: use argv_array API Jeff King
2011-09-13 21:58 ` [PATCH 6/7] checkout: " Jeff King
2011-09-13 21:58 ` [PATCH 7/7] run_hook: " Jeff King
2011-09-13 22:04 ` [nit] diff func headers ignore context Jeff King
2011-09-14 10:13 ` Andreas Ericsson
2011-09-14 19:01 ` Junio C Hamano
2011-09-14 18:54 ` Junio C Hamano [this message]
2011-09-14 18:56 ` [PATCH 7/7] run_hook: use argv_array API Jeff King
2011-09-14 20:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vty8ft0oc.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.