From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] compat/regex: define out variables only used under RE_ENABLE_I18N
Date: Thu, 19 Aug 2010 13:02:22 -0700 [thread overview]
Message-ID: <7vtymq74mp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1282242601-2630-1-git-send-email-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu\, 19 Aug 2010 18\:30\:01 +0000")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Wrap variables that were only used RE_ENABLE_I18N in `#ifdef
> RE_ENABLE_I18N`. This eliminates compiler warnings when compiling with
> NO_REGEX=YesPlease.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Hmm, this unfortunately is not enough for me to compile it locally.
In file included from compat/regex/regex.c:77:
compat/regex/regcomp.c: In function 're_compile_pattern':
compat/regex/regcomp.c:237: error: old-style function definition
compat/regex/regcomp.c: In function 're_set_syntax':
compat/regex/regcomp.c:276: error: old-style function definition
compat/regex/regcomp.c: In function 're_compile_fastmap':
compat/regex/regcomp.c:289: error: old-style function definition
compat/regex/regcomp.c: In function 'regcomp':
compat/regex/regcomp.c:491: error: old-style function definition
compat/regex/regcomp.c: In function 'regfree':
compat/regex/regcomp.c:655: error: old-style function definition
In file included from compat/regex/regex.c:78:
compat/regex/regexec.c: In function 'regexec':
compat/regex/regexec.c:227: error: old-style function definition
compat/regex/regexec.c: In function 're_match':
compat/regex/regexec.c:311: error: old-style function definition
compat/regex/regexec.c: In function 're_search':
compat/regex/regexec.c:324: error: old-style function definition
compat/regex/regexec.c: In function 're_match_2':
compat/regex/regexec.c:337: error: old-style function definition
compat/regex/regexec.c: In function 're_search_2':
compat/regex/regexec.c:351: error: old-style function definition
compat/regex/regexec.c: In function 're_search_2_stub':
compat/regex/regexec.c:366: error: old-style function definition
compat/regex/regexec.c: In function 're_search_stub':
compat/regex/regexec.c:410: error: old-style function definition
compat/regex/regexec.c: In function 're_copy_regs':
compat/regex/regexec.c:497: error: old-style function definition
compat/regex/regexec.c: In function 're_set_registers':
compat/regex/regexec.c:578: error: old-style function definition
compat/regex/regexec.c: In function 're_search_internal':
compat/regex/regexec.c:631: error: old-style function definition
compat/regex/regexec.c: In function 'prune_impossible_nodes':
compat/regex/regexec.c:952: error: old-style function definition
make: *** [compat/regex/regex.o] Error 1
The fix should be straightforward, and I think it should be squashed with
the header ANSIfication you sent earlier.
Thanks.
next prev parent reply other threads:[~2010-08-19 20:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 22:27 What's cooking in git.git (Aug 2010, #04; Wed, 18) Junio C Hamano
2010-08-19 3:02 ` Jonathan Nieder
2010-08-19 8:06 ` Johannes Sixt
2010-08-19 12:48 ` Ævar Arnfjörð Bjarmason
2010-08-19 15:04 ` Ævar Arnfjörð Bjarmason
[not found] ` <AANLkTinkjsLycvV-uvfG14t7Q=uKt+pnpizKCPGirVW1@mail.gmail.com>
2010-08-19 18:05 ` Fwd: " Aharon Robbins
2010-08-19 18:30 ` [PATCH] compat/regex: define out variables only used under RE_ENABLE_I18N Ævar Arnfjörð Bjarmason
2010-08-19 20:02 ` Junio C Hamano [this message]
2010-08-19 20:31 ` Ævar Arnfjörð Bjarmason
2010-08-19 21:07 ` Junio C Hamano
2010-08-19 21:30 ` Ævar Arnfjörð Bjarmason
2010-08-19 22:45 ` [PATCH] compat/regex: get rid of old-style definition Junio C Hamano
2010-08-20 7:47 ` Ævar Arnfjörð Bjarmason
2010-08-25 18:24 ` Karsten Blees
2010-08-26 7:58 ` [PATCH] Fix compat/regex ANSIfication on MinGW Johannes Sixt
2010-08-26 20:34 ` Ævar Arnfjörð Bjarmason
2010-09-03 21:23 ` karsten.blees
2010-09-03 22:21 ` Ævar Arnfjörð Bjarmason
2010-09-04 5:22 ` Junio C Hamano
2010-09-07 12:56 ` Johannes Sixt
2010-08-19 3:22 ` jn/update-contrib-example-merge in pu Jonathan Nieder
2010-08-19 12:53 ` What's cooking in git.git (Aug 2010, #04; Wed, 18) Ævar Arnfjörð Bjarmason
2010-08-19 15:27 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtymq74mp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.