All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: William Pursell <bill.pursell@gmail.com>,
	Andreas Schwab <schwab@linux-m68k.org>,
	git@vger.kernel.org
Subject: Re: permissions
Date: Tue, 08 Jun 2010 14:05:30 -0700	[thread overview]
Message-ID: <7vtypds09x.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: AANLkTimAmSxq8dC-4bnpLsvN3JabQeTO6pDTh9ds7D0D@mail.gmail.com

Alex Riesen <raa.lkml@gmail.com> writes:

> On Tue, Jun 8, 2010 at 12:25, William Pursell <bill.pursell@gmail.com> wrote:
>> Here's a patch.  This doesn't address the issue of a damaged
>> repository, but just catches access errors and permissions.
>
> The change looks fishy.
>
> The patch moves the function is_git_directory at the level of user
> interface where it wasn't before: it now complains and die.
> Not all callers of the function call it only to die if it fails.

Thanks for shooting it down before I had to look at it ;-)

  reply	other threads:[~2010-06-08 21:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05  9:33 permissions William Pursell
2010-06-05  9:50 ` permissions Andreas Schwab
2010-06-05 18:23   ` permissions William Pursell
2010-06-06  6:45     ` permissions Alex Riesen
2010-06-06  9:36       ` permissions William Pursell
2010-06-06 12:45         ` permissions Alex Riesen
2010-06-06 19:54         ` permissions Junio C Hamano
2010-06-08 10:25           ` permissions William Pursell
2010-06-08 14:52             ` permissions Alex Riesen
2010-06-08 21:05               ` Junio C Hamano [this message]
2010-06-08 22:27                 ` permissions William Pursell
2010-06-09  7:20                   ` permissions Alex Riesen
2010-06-09 10:29                     ` permissions William Pursell
2010-06-09 12:06                       ` permissions Thomas Rast
2010-06-09 13:00                         ` permissions Alex Riesen
2010-06-09 12:56                       ` permissions Alex Riesen
2010-06-09 10:39                     ` permissions Steven Michalske
  -- strict thread matches above, loose matches on Subject: below --
2015-06-29 14:49 permissions dark.star777-NKkJACngtoFBDgjK7y7TUQ
     [not found] <454655BC.30606@blueyonder.co.uk>
     [not found] ` <20061030213355.GA25496@cloud.net.au>
     [not found]   ` <45469110.4070108@blueyonder.co.uk>
     [not found]     ` <20061031012432.GA6698@cloud.net.au>
2006-10-31 10:50       ` permissions richard
2002-07-08  8:04 permissions Nicolas Brainez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtypds09x.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=bill.pursell@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.