All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Lea Wiemann <lewiemann@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] gitweb: quote commands properly when calling the shell
Date: Tue, 17 Jun 2008 16:41:08 -0700	[thread overview]
Message-ID: <7vtzfr3a0b.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1213739195-29284-1-git-send-email-LeWiemann@gmail.com> (Lea Wiemann's message of "Tue, 17 Jun 2008 23:46:35 +0200")

Lea Wiemann <lewiemann@gmail.com> writes:

> This eliminates the function git_cmd_str, which was used for composing
> command lines, and adds a quote_command function, which quotes all of
> its arguments (as in quote.c).

Looks sane.  Thanks.

  parent reply	other threads:[~2008-06-17 23:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17  1:09 [PATCH] gitweb: fix support for repository directories with spaces Lea Wiemann
2008-06-17  1:14 ` Junio C Hamano
2008-06-17 21:27   ` Junio C Hamano
2008-06-17 21:46   ` [PATCH v2] gitweb: quote commands properly when calling the shell Lea Wiemann
2008-06-17 21:51     ` Lea Wiemann
2008-06-17 23:41     ` Junio C Hamano [this message]
2008-06-17  1:38 ` [PATCH] gitweb: fix support for repository directories with spaces Jakub Narebski
2008-06-17 22:07   ` Lea Wiemann
2008-06-17 22:27     ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtzfr3a0b.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=lewiemann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.