All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Dave Jones <davej@redhat.com>,
	Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH] Fix use after free() in builtin-fetch
Date: Tue, 29 Apr 2008 00:30:42 -0700	[thread overview]
Message-ID: <7vtzhl6rtp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080428202335.GA10600@steel.home> (Alex Riesen's message of "Mon, 28 Apr 2008 22:23:35 +0200")

Alex Riesen <raa.lkml@gmail.com> writes:

> As reported by Dave Jones:
> ...
> export MALLOC_PERTURB_=$(($RANDOM % 255 + 1))
>
> which is handy for showing up such bugs.
>
> More info on this glibc feature is at http://udrepper.livejournal.com/11429.html
>
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>

Thanks.  I can reproduce the issue and the fix (and can even bisect this
down to ba22785 (Reduce the number of connects when fetching, 2008-02-04),
which makes perfect sense).

Will apply to 'maint' and merge up.

      reply	other threads:[~2008-04-29  7:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28 18:41 git-fetch segfault in git 1.5.5.1 Dave Jones
2008-04-28 20:23 ` [PATCH] Fix use after free() in builtin-fetch Alex Riesen
2008-04-29  7:30   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vtzhl6rtp.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=barkalow@iabervon.org \
    --cc=davej@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.