From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string
Date: Mon, 13 May 2013 06:58:28 -0700 [thread overview]
Message-ID: <7vvc6noubf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130513111143.GU2331@goldbirke> ("SZEDER Gábor"'s message of "Mon, 13 May 2013 13:11:43 +0200")
SZEDER Gábor <szeder@ira.uka.de> writes:
> On Mon, May 13, 2013 at 01:05:51PM +0200, SZEDER Gábor wrote:
>> On Mon, May 13, 2013 at 03:43:43PM +0530, Ramkumar Ramachandra wrote:
>> > If we can agree that it's just a matter of taste, we should both be
>> > able to have what we want. Any suggestions on how to make this
>> > configurable?
>>
>> The same way we make other things configurable in the prompt: specify
>> the GIT_PS1_HIDESTATESEPARATOR or something similar variable to strip
>> that space from the prompt.
>
> Or perhaps better yet: use a variable, e.g. GIT_PS1_STATESEPARATOR or
> whatever, to specify what should separate the branch name from the
> repo state, defaulting to a space to keep the current behavior.
Why just a single knob for that SP?
If you restructure the code to formulate "gitstring" to call a shell
function to do so, people can override it and come up with whatever
format they want to use, no?
next prev parent reply other threads:[~2013-05-13 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 16:25 [PATCH 0/2] Colored prompt for zsh Ramkumar Ramachandra
2013-05-11 16:25 ` [PATCH 1/2] git-prompt.sh: strip unnecessary space in prompt string Ramkumar Ramachandra
2013-05-13 4:57 ` Junio C Hamano
2013-05-13 7:40 ` Ramkumar Ramachandra
2013-05-13 9:17 ` SZEDER Gábor
2013-05-13 10:13 ` Ramkumar Ramachandra
2013-05-13 11:05 ` SZEDER Gábor
2013-05-13 11:11 ` SZEDER Gábor
2013-05-13 13:58 ` Junio C Hamano [this message]
2013-05-13 14:21 ` Ramkumar Ramachandra
2013-05-11 16:25 ` [PATCH 2/2] git-prompt.zsh: introduce thin ZSH wrapper Ramkumar Ramachandra
2013-05-11 21:26 ` Felipe Contreras
2013-05-11 22:18 ` [PATCH v2] git-prompt.sh: colorize ZSH prompt Ramkumar Ramachandra
2013-05-11 22:29 ` Felipe Contreras
2013-05-11 22:40 ` Ramkumar Ramachandra
2013-05-11 23:06 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvc6noubf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.