From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
Git List <git@vger.kernel.org>, Thomas Rast <trast@inf.ethz.ch>
Subject: Re: [PATCH 4/5] git-log.txt: rewrite note on why "--" may be required
Date: Sun, 21 Apr 2013 01:33:23 -0700 [thread overview]
Message-ID: <7vvc7guvu4.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130421080907.GF10429@elie.Belkin> (Jonathan Nieder's message of "Sun, 21 Apr 2013 01:09:07 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Ramkumar Ramachandra wrote:
>
>> I would say the most technically accurate
>> description of what 'git log' takes is a "committish range" (basically
>> a "revision range" that resolves to commits).
>
> What is a revision range that doesn't resolve to commits? Am I wrong
> in thinking revision is nothing more than a synonym for commit?
>
> When gitrevisions(7) says "A revision parameter <rev> typically, but
> not necessarily, names a commit object", I suspect it is residue from
> 3a45f625 trying to apologize for the extended SHA1 syntax parser being
> called "git rev-parse" instead of "git object-name-parse".
- A revision range is a slice of history. There is no need for
"committish revision range" as there is no other kinds of ranges.
- A revision should be a synonym to a committish, as glossary
defines. We historically used "revision" more or less
interchangeably with "object name", especially "an extended SHA-1
expression that is used as an object name", to mean whatever
get_sha1() can grok down to a single object name. This must be
rectified to avoid causing confusion to new readers of our
documentation.
- Documentation/revisions.txt needs to be cleaned up. It lists
"specifying revisions" and "specifying ranges", which is a good
start primarily because some notations used in ranges are not
revisions (e.g. "^C"), but it should have three (not two) sections.
They are: "specifying revisions", "specifying object names", and
"specifying ranges". Move non committish specification such as
<revision>:<path> from the current "specifying revisions" section
and make the new "object names" section. The "ranges" section is
already written in terms of revisions, and does not need any
update, once we clarify the definition of a "revision" as
"committish".
next prev parent reply other threads:[~2013-04-21 8:33 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 11:45 [PATCH 0/5] Documentation/shortlog improvements Ramkumar Ramachandra
2013-04-20 11:45 ` [PATCH 1/5] git-shortlog.txt: remove (-h|--help) from OPTIONS Ramkumar Ramachandra
2013-04-20 11:45 ` [PATCH 2/5] builtin/shortlog.c: make usage string consistent with log Ramkumar Ramachandra
2013-04-20 11:45 ` [PATCH 3/5] git-log.txt: fix description of <since>..<until> Ramkumar Ramachandra
2013-04-20 22:25 ` Jonathan Nieder
2013-04-21 7:18 ` Ramkumar Ramachandra
2013-04-21 7:41 ` Jonathan Nieder
[not found] ` <CAPc5daVcovqrHP-YWnkcQWwev5TW5S8ioX-bWyAnNG2PTg_XMw@mail.gmail.com>
2013-04-21 8:17 ` [PATCH/RFC] glossary: a revision is just a commit Jonathan Nieder
2013-04-21 19:00 ` Junio C Hamano
2013-04-21 7:19 ` [PATCH 3/5] git-log.txt: fix description of <since>..<until> Junio C Hamano
2013-04-21 6:40 ` Junio C Hamano
2013-04-20 11:45 ` [PATCH 4/5] git-log.txt: rewrite note on why "--" may be required Ramkumar Ramachandra
2013-04-21 6:51 ` Junio C Hamano
2013-04-21 7:26 ` Ramkumar Ramachandra
2013-04-21 7:33 ` Junio C Hamano
2013-04-21 7:38 ` Ramkumar Ramachandra
2013-04-21 7:46 ` Junio C Hamano
2013-04-21 8:00 ` Ramkumar Ramachandra
2013-04-21 8:09 ` Jonathan Nieder
2013-04-21 8:15 ` Ramkumar Ramachandra
2013-04-21 8:17 ` Jonathan Nieder
2013-04-21 8:33 ` Junio C Hamano [this message]
2013-04-21 9:05 ` Ramkumar Ramachandra
2013-04-21 9:46 ` Ramkumar Ramachandra
2013-04-21 10:09 ` Jonathan Nieder
[not found] ` <CAPc5daV39HsoRR2pj34Tz1kQKFVRrp+NZpMM2BremocqvToA+A@mail.gmail.com>
2013-04-21 8:13 ` Ramkumar Ramachandra
2013-04-21 8:23 ` Ramkumar Ramachandra
2013-04-21 7:39 ` Junio C Hamano
2013-04-21 7:57 ` Ramkumar Ramachandra
2013-04-22 2:40 ` Junio C Hamano
2013-04-22 9:36 ` Thomas Rast
2013-04-22 9:40 ` Thomas Rast
2013-04-22 14:55 ` Junio C Hamano
2013-04-20 11:45 ` [PATCH 5/5] git-shortlog.txt: make SYNOPSIS match log, update OPTIONS Ramkumar Ramachandra
2013-04-21 7:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvc7guvu4.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.