From: Junio C Hamano <gitster@pobox.com>
To: Miles Bader <miles@gnu.org>
Cc: Paul Campbell <pcampbell@kemitix.net>, git <git@vger.kernel.org>,
David Greene <greened@obbligato.org>
Subject: Re: [PATCH 0/4] contrib/subtree: general updates
Date: Wed, 13 Mar 2013 20:30:38 -0700 [thread overview]
Message-ID: <7vvc8uzmht.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <874ngebsm9.fsf@catnip.gol.com> (Miles Bader's message of "Thu, 14 Mar 2013 11:52:14 +0900")
Miles Bader <miles@gnu.org> writes:
> Paul Campbell <pcampbell@kemitix.net> writes:
>> James and Michael's patches add if clauses that use the
>> bashism 'if []' rather than 'if test'.
>
> "Bashism"...? I dunno how portable is, but "[" is an old unix alias
> for "test" ... it certainly predates bash...
Correct. [[ ... ]] is new and spelling out "test" indeed is more
traditionalist than [ ... ], but for contrib/subtree/ that does not
work with anything but bash, I do not think such a rewrite has much
merit in the first place. Being consistently "bash script" (as
opposed to being old-style) is more appropriate for it.
next prev parent reply other threads:[~2013-03-14 3:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:32 [PATCH 0/4] contrib/subtree: general updates Paul Campbell
2013-03-13 22:32 ` [PATCH 1/4] contrib/subtree: Teach push to abort if split fails Paul Campbell
2013-03-13 22:32 ` [PATCH 2/4] contrib/subtree: Teach push to use --force option Paul Campbell
2013-03-13 22:32 ` [PATCH 3/4] contrib/subtree: Fix typo (s/incldued/included/) Paul Campbell
2013-03-13 22:32 ` [PATCH 4/4] contrib/subtree: Replace invisible carriage return with a visible \r Paul Campbell
2013-03-13 22:36 ` Paul Campbell
2013-03-13 22:42 ` [PATCH] " Paul Campbell
2013-03-14 2:52 ` [PATCH 0/4] contrib/subtree: general updates Miles Bader
2013-03-14 3:30 ` Junio C Hamano [this message]
2013-03-24 0:16 ` Paul Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvc8uzmht.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=greened@obbligato.org \
--cc=miles@gnu.org \
--cc=pcampbell@kemitix.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.