All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Daniel Lyubomirov <daniel@digitalus.bg>, git@vger.kernel.org
Subject: Re: Bug: problem with file named with dash character
Date: Wed, 27 Jun 2012 13:48:42 -0700	[thread overview]
Message-ID: <7vvcic7a6t.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vzk7o7am5.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 27 Jun 2012 13:39:30 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Junio C Hamano <gitster@pobox.com> writes:
>>>
>>>> Jeff King <peff@peff.net> writes:
>>>>
>>>>> but that code path should be fixed properly (with a use_stdin flag in
>>>>> the filespec).
>>>>
>>>> Yes, just as I said; I am finding more and more issues with the
>>>> no-index hack that I have been fixing a bit by bit since I send the
>>>> message you responded to.
>>>
>>> It is not ready yet, but here are a few patches WIP.
>>
>> And this is the second clean-up
>
> And this is the third one.

Some of the other breakages that comes from the "no-index" codepath
that we may want to consider addressing I have found so far are:

 - We say on the "diff --git" header uglyness like "a/-", "b/-";
   likewise in the metainfo;

 - We show on the "index" header "0*" value for these entries, even
   though we should be able to compute it (after all we do so for
   files on disk in a non-git directory);

 - We still apply attributes and textconv as if we are dealing with
   a regular file "-" at the root level.

  reply	other threads:[~2012-06-27 20:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <52ae7682-3e9a-4b52-bec1-08ba3aadffc0@office.digitalus.nl>
2012-06-27  7:32 ` Bug: problem with file named with dash character Daniel Lyubomirov -|- Digitalus Bulgaria
2012-06-27  9:57   ` faux
2012-06-27 18:28   ` Junio C Hamano
2012-06-27 19:52     ` Jeff King
2012-06-27 20:25       ` Jeff King
2012-06-27 20:27       ` Junio C Hamano
2012-06-27 20:33         ` Junio C Hamano
2012-06-27 20:35           ` Junio C Hamano
2012-06-27 20:39             ` Junio C Hamano
2012-06-27 20:48               ` Junio C Hamano [this message]
2012-06-27 21:00                 ` Jeff King
2012-06-27 22:17                   ` Junio C Hamano
2012-06-27 22:41                     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvcic7a6t.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=daniel@digitalus.bg \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.