All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Thiago Farina <tfransosi@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] help.c: Pull cmd_version out of this file.
Date: Thu, 02 Sep 2010 09:31:44 -0700	[thread overview]
Message-ID: <7vvd6o14zz.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20100902043500.GF29713@burratino> (Jonathan Nieder's message of "Wed\, 1 Sep 2010 23\:35\:00 -0500")

Jonathan Nieder <jrnieder@gmail.com> writes:

> Thiago Farina wrote:
>
>> All patches should just fix real problems?
>
> Yes.

This answer while it is correct needs to be qualified ;-)

A bugfix for end-user facing part of the system is obviously a fix for a
"real problem", but clean-up without changing external behaviour to reduce
maintenance burden in the longer term also is fixing a real problem, i.e.
"the code, while it might be bug-free, is error prone and costs a lot to
maintain".

  reply	other threads:[~2010-09-02 16:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-29 20:44 [PATCH] help.c: Pull cmd_version out of this file Thiago Farina
2010-08-30  2:38 ` Jonathan Nieder
2010-08-30  2:40   ` Jonathan Nieder
2010-09-01  2:38     ` Thiago Farina
2010-09-01  3:04       ` Nguyen Thai Ngoc Duy
2010-09-01  3:11         ` Thiago Farina
2010-09-01  6:11       ` Junio C Hamano
2010-09-01  6:22         ` Thiago Farina
2010-09-02  1:04           ` Junio C Hamano
2010-09-02  1:16             ` Thiago Farina
2010-09-02  4:35           ` Jonathan Nieder
2010-09-02 16:31             ` Junio C Hamano [this message]
2010-10-27 15:12               ` Thiago Farina
2010-10-27 15:18                 ` Jonathan Nieder
2010-10-27 16:06                   ` Thiago Farina
2010-10-27 16:45                     ` Jonathan Nieder
2010-10-28  2:13                       ` Thiago Farina
2010-10-28  3:11                         ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvd6o14zz.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.