From: Junio C Hamano <gitster@pobox.com>
To: Clemens Buchacher <drizzd@aon.at>
Cc: git@vger.kernel.org, johannes@familieschneider.info
Subject: Re: [PATCH 3/3] implement pattern matching in ce_path_match
Date: Wed, 14 Jan 2009 14:27:03 -0800 [thread overview]
Message-ID: <7vvdshzfpk.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090114192341.GA26703@localhost> (Clemens Buchacher's message of "Wed, 14 Jan 2009 20:23:41 +0100")
Clemens Buchacher <drizzd@aon.at> writes:
> I think we could at least add an option to disable globbing. Then we can
> also disable the above check conditioned on that. If we allowed globbing
> pattern for following renames wouldn't that result in following the first
> file (or last in history) to match the pattern, which is potentially
> confusing?
Yeah, I agree that would be a reasonable thing to do.
In places we read paths from the index or from the work tree and add them
as pathspec elements---you would want to mark them as non-globbing, too.
Which probably means that "is it Ok to glob this" setting has to be per
pathspec array elements.
next prev parent reply other threads:[~2009-01-14 22:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 14:54 [PATCH 0/3] fix "git add" pattern matching Clemens Buchacher
2009-01-14 14:54 ` [PATCH 1/3] clean up pathspec matching Clemens Buchacher
2009-01-14 14:54 ` [PATCH 2/3] remove pathspec_match, use match_pathspec instead Clemens Buchacher
2009-01-14 14:54 ` [PATCH 3/3] implement pattern matching in ce_path_match Clemens Buchacher
2009-01-14 15:25 ` Clemens Buchacher
2009-01-14 15:44 ` Johannes Schindelin
2009-01-14 15:55 ` Sverre Rabbelier
2009-01-14 16:18 ` Samuel Tardieu
2009-01-14 16:53 ` Jeff King
2009-01-14 18:39 ` Junio C Hamano
2009-01-14 19:23 ` Clemens Buchacher
2009-01-14 22:27 ` Junio C Hamano [this message]
2009-01-15 8:20 ` Clemens Buchacher
2009-01-16 2:51 ` Junio C Hamano
2009-01-14 15:40 ` [PATCH 2/3] remove pathspec_match, use match_pathspec instead Johannes Schindelin
2009-01-14 16:09 ` Clemens Buchacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdshzfpk.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=johannes@familieschneider.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.