From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Pieter de Bie <pdebie@ai.rug.nl>,
Git Mailinglist <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig
Date: Fri, 27 Jun 2008 15:40:48 -0700 [thread overview]
Message-ID: <7vvdzuo61b.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0806271149580.19665@iabervon.org> (Daniel Barkalow's message of "Fri, 27 Jun 2008 12:05:39 -0400 (EDT)")
Daniel Barkalow <barkalow@iabervon.org> writes:
> On Fri, 27 Jun 2008, Johannes Schindelin wrote:
>
>> After initializing the config in the newly-created repository, we
>> need to unset GIT_CONFIG so that the global configs are read again.
>
> This seems fine to me. OTOH, I'm not sure the environment variable should
> be needed in the first place; I think the config stuff should look in
> git_path("config") without it, and we set the git dir to the one we're
> initializing. So I think the use of the environment variable is just an
> artifact of how the shell script did it and how I was originally calling
> the init_db stuff.
>
> Just removing the "setenv()" line survives all of the tests for me, and I
> remember some of them failing before I'd gotten some sort of solution for
> the config stuff.
Ok, I take that you are Ok with 2/2 but you have a better replacement
patch coming for this 1/2?
next prev parent reply other threads:[~2008-06-27 22:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 9:35 Using url.insteadOf in git-clone Pieter de Bie
2008-06-27 12:55 ` [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig Johannes Schindelin
2008-06-27 12:56 ` [PATCH 2/2] clone: respect url.insteadOf setting in global configs Johannes Schindelin
2008-06-27 16:08 ` Daniel Barkalow
2008-06-29 20:12 ` Pieter de Bie
2008-06-29 21:50 ` Johannes Schindelin
2008-06-27 16:05 ` [PATCH 1/2] clone: respect the settings in $HOME/.gitconfig and /etc/gitconfig Daniel Barkalow
2008-06-27 22:40 ` Junio C Hamano [this message]
2008-06-29 18:31 ` Daniel Barkalow
2008-06-29 20:36 ` Junio C Hamano
2008-06-29 21:49 ` Johannes Schindelin
2008-06-29 22:47 ` Daniel Barkalow
2008-06-30 0:41 ` Johannes Schindelin
2008-06-30 1:54 ` Daniel Barkalow
2008-06-30 1:20 ` Junio C Hamano
2008-06-30 2:21 ` Daniel Barkalow
2008-06-30 3:47 ` Daniel Barkalow
2008-06-30 11:57 ` Johannes Schindelin
2008-06-30 16:47 ` Daniel Barkalow
2008-06-30 6:20 ` Junio C Hamano
2008-06-30 6:25 ` Junio C Hamano
2008-06-30 6:40 ` Jeff King
2008-06-30 6:44 ` Junio C Hamano
2008-06-30 11:37 ` Johannes Schindelin
2008-06-27 17:11 ` Using url.insteadOf in git-clone Junio C Hamano
2008-06-29 18:59 ` Pieter de Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vvdzuo61b.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.