From: Junio C Hamano <gitster@pobox.com>
To: Shawn Bohrer <shawn.bohrer@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Add more tests for git-clean
Date: Sun, 04 Nov 2007 15:35:42 -0800 [thread overview]
Message-ID: <7vve8hr3ch.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <11942029442710-git-send-email-shawn.bohrer@gmail.com> (Shawn Bohrer's message of "Sun, 4 Nov 2007 13:02:20 -0600")
Shawn Bohrer <shawn.bohrer@gmail.com> writes:
> +test_expect_success 'git-clean with prefix' '
> +
> + mkdir -p build docs &&
> + touch a.out src/part3.c docs/manual.txt obj.o build/lib.so &&
> + cd src/ &&
> + git-clean &&
> + cd - &&
This is wrong for two reasons.
- Is "cd -" portable?
- What happens when git-clean fails? This test fails, and then
it goes on to the next test without cd'ing back.
next prev parent reply other threads:[~2007-11-04 23:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 19:02 [RFC] Second attempt at making git-clean a builtin Shawn Bohrer
2007-11-04 19:02 ` [PATCH] Add more tests for git-clean Shawn Bohrer
2007-11-04 19:02 ` [PATCH] Make git-clean a builtin Shawn Bohrer
2007-11-04 19:41 ` Pierre Habouzit
2007-11-04 20:24 ` [PATCH 3/2] Use parse-options in builtin-clean Johannes Schindelin
2007-11-04 21:16 ` Pierre Habouzit
2007-11-05 21:14 ` [PATCH] Make git-clean a builtin Junio C Hamano
2007-11-05 22:10 ` Carlos Rica
2007-11-05 23:54 ` Junio C Hamano
2007-11-06 5:05 ` Shawn Bohrer
2007-11-06 5:30 ` Junio C Hamano
2007-11-04 23:35 ` Junio C Hamano [this message]
2007-11-04 23:46 ` [PATCH] Add more tests for git-clean Pierre Habouzit
2007-11-05 0:17 ` Junio C Hamano
2007-11-04 23:49 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2007-11-05 4:28 Shawn Bohrer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vve8hr3ch.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=shawn.bohrer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.