All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] honor GIT_REFLOG_ACTION in git-commit
Date: Fri, 19 Jan 2007 18:22:06 -0800	[thread overview]
Message-ID: <7vvej2a14h.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070120021557.GB11073@spearce.org> (Shawn O. Pearce's message of "Fri, 19 Jan 2007 21:15:58 -0500")

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Junio C Hamano <junkio@cox.net> wrote:
>> This allows git-cherry-pick and git-revert to properly identify
>> themselves in the resulting reflog entries.  Earlier they were
>> recorded as what git-commit has done.
>
> Not sure how I missed that one when I introduced GIT_REFLOG_ACTION,
> but thanks for finding and fixing it.  :-)

The fact that it went unnoticed for this long time shows how we
lack proper tools to read the message part of the reflog,
although we use @{N} and @{ago} notation every day and some
people might even rely on it.  I'd like to do something about
it, and my earlier "show-branch --reflog" enhancement series
(I'll park that in 'next' for now) was my attempt for that goal.

I found this out by accident while working on it.

      reply	other threads:[~2007-01-20  2:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-20  1:12 [PATCH] honor GIT_REFLOG_ACTION in git-commit Junio C Hamano
2007-01-20  2:15 ` Shawn O. Pearce
2007-01-20  2:22   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvej2a14h.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.