All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Jeff King <peff@peff.net>
Cc: Martin Langhoff <martin.langhoff@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying
Date: Thu, 23 Nov 2006 18:54:32 -0800	[thread overview]
Message-ID: <7vvel5ftav.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20061124014205.GA19515@sigio.intra.peff.net> (Jeff King's message of "Thu, 23 Nov 2006 20:42:05 -0500")

Jeff King <peff@peff.net> writes:

> On Fri, Nov 24, 2006 at 12:52:13PM +1300, Martin Langhoff wrote:
>
>> You are right. It should be something along the lines of
>> 
>>  # discard headers until first blank line
>>  while (<$s> ne '') {
>>      # nothing
>>  }
>> 
>> that is, assuming we can just ignore headers happily.
>
> That code won't work; the value of a blank line will actually be "\n"
> (or "\r\n").

Good point.  For an HTTP proxy the kosher line termination would
indeed be "\r\n".

  reply	other threads:[~2006-11-24  2:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22 22:26 [PATCH] git-cvsimport: add suport for CVS pserver method HTTP/1.x proxying Inaki Arenaza
     [not found] ` <7v64 d5keke.fsf@assigned-by-dhcp.cox.net>
2006-11-23 22:01 ` Junio C Hamano
2006-11-23 22:09   ` Martin Langhoff (CatalystIT)
2006-11-23 23:02     ` Junio C Hamano
2006-11-23 23:20       ` Martin Langhoff (CatalystIT)
2006-11-23 23:52       ` Martin Langhoff
2006-11-24  0:24         ` Junio C Hamano
2006-11-25 12:43           ` Ignacio Arenaza
2006-11-24  1:42         ` Jeff King
2006-11-24  2:54           ` Junio C Hamano [this message]
2006-11-24  8:43   ` Ignacio Arenaza
2006-11-24  8:46   ` Ignacio Arenaza
2006-11-24  8:57     ` Junio C Hamano
2006-11-24  9:05       ` Ignacio Arenaza
2006-11-24 11:48         ` Junio C Hamano
2006-11-27 16:27           ` Ignacio Arenaza
2006-11-24 14:57       ` Jeff King
2006-11-24  4:48 ` Christian Couder
2006-11-24  8:41   ` Ignacio Arenaza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vvel5ftav.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=martin.langhoff@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.