From: Junio C Hamano <gitster@pobox.com>
To: Lea Wiemann <lewiemann@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] cat-file --batch / --batch-check: do not exit if hashes are missing
Date: Mon, 09 Jun 2008 13:42:57 -0700 [thread overview]
Message-ID: <7vwskyfige.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1212969741-24899-1-git-send-email-LeWiemann@gmail.com
Lea Wiemann <lewiemann@gmail.com> writes:
> diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
> index 973aef7..542b4ae 100755
> --- a/t/t1006-cat-file.sh
> +++ b/t/t1006-cat-file.sh
> @@ -174,9 +174,27 @@ do
> ...
> +foobar84 missing" = \
> + "$(( echo foobar42; echo_without_newline foobar84; ) | git cat-file --batch-check)"
I have a slight suspicion that some of the Bourne shell implementations we
support may misinterpret $(( as beginning of arithmetic expansion, so
perhaps we would want an extra SP between the open parens.
Other than that, looked ok.
next prev parent reply other threads:[~2008-06-09 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 23:28 [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing Lea Wiemann
2008-06-08 23:34 ` Johannes Schindelin
2008-06-09 0:05 ` Lea Wiemann
2008-06-09 1:02 ` Johannes Schindelin
2008-06-09 10:17 ` Lea Wiemann
2008-06-09 11:07 ` Jakub Narebski
2008-06-09 13:27 ` Lea Wiemann
2008-06-09 0:02 ` [PATCH v2] " Lea Wiemann
2008-06-09 20:37 ` Junio C Hamano
2008-06-09 20:42 ` Junio C Hamano [this message]
2008-06-09 14:23 ` [PATCH] " Johannes Sixt
2008-06-09 18:21 ` Lea Wiemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwskyfige.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lewiemann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.