All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] A test for commit --amend allowing changing of a very empty commit message
Date: Thu, 21 Feb 2008 12:23:10 -0800	[thread overview]
Message-ID: <7vwsoyt5xt.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080221195438.GA6973@steel.home> (Alex Riesen's message of "Thu, 21 Feb 2008 20:54:38 +0100")

Alex Riesen <raa.lkml@gmail.com> writes:

> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
>
> Well, it fails... In current master

Then please mark it with test_expect_failure.

> +test_expect_success 'allow amend of an empty message' '
> +
> +	git reset --hard &&
> +	sha=$(:|git commit-tree HEAD^{tree} -p HEAD) &&

You do not have to pipe; </dev/null would do ;-).

  reply	other threads:[~2008-02-21 20:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 19:54 [PATCH] A test for commit --amend allowing changing of a very empty commit message Alex Riesen
2008-02-21 20:23 ` Junio C Hamano [this message]
2008-02-21 20:35   ` Alex Riesen
2008-02-21 20:38     ` [PATCH] Fix amending of a commit with an empty message Alex Riesen
2008-02-21 20:56       ` Junio C Hamano
2008-02-21 21:32         ` Alex Riesen
2008-02-21 22:01           ` Junio C Hamano
2008-02-21 20:57     ` [PATCH] A test for commit --amend allowing changing of a very empty commit message Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsoyt5xt.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.