From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH 2/6] Automatically close stderr pipes created by run_command
Date: Sat, 16 Feb 2008 00:25:30 -0800 [thread overview]
Message-ID: <7vwsp5b951.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <47B3F51C.3060002@viscovery.net> (Johannes Sixt's message of "Thu, 14 Feb 2008 09:00:28 +0100")
Johannes Sixt <j.sixt@viscovery.net> writes:
> Shawn O. Pearce schrieb:
>> Like the out pipe and in pipe, we now automatically close the err
>> pipe if it was requested by the caller and it hasn't been closed
>> by the caller. This simplifies anyone who wants to get a pipe to
>> the stderr stream for another process.
>
> IMHO, this is backwards.
>
> The .in, .out, .err members of struct child_process serve two different
> purposes:
> ...
> Notice that in a clean implementation:
> ...
> The current implementation of start_command/finish_command as well as its
> callers don't follow these rules (because they are not documented
> anywhere).
We should define what the clean semantics of this API should be,
and update Documentation/technical/api-run-command.txt, before
going any further.
And I happen to notice two of your names in the list of people
who have been involved in its evolution ;-).
prev parent reply other threads:[~2008-02-16 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 6:22 [PATCH 2/6] Automatically close stderr pipes created by run_command Shawn O. Pearce
2008-02-14 8:00 ` Johannes Sixt
2008-02-15 17:11 ` Junio C Hamano
2008-02-15 19:45 ` Johannes Sixt
2008-02-15 22:14 ` Junio C Hamano
2008-02-16 17:36 ` [PATCH] start_command(), .in/.out/.err = -1: Callers must close the file descriptor Johannes Sixt
2008-02-16 17:36 ` [PATCH] start_command(), if .in/.out > 0, closes file descriptors, not the callers Johannes Sixt
2008-02-16 22:55 ` Junio C Hamano
2008-02-17 7:42 ` Shawn O. Pearce
2008-02-17 8:07 ` Junio C Hamano
2008-02-17 8:20 ` Shawn O. Pearce
2008-02-17 9:29 ` Johannes Sixt
2008-02-21 22:42 ` [PATCH v2] " Johannes Sixt
2008-02-22 1:17 ` Junio C Hamano
2008-02-16 8:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vwsp5b951.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.