All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Michal Vitecek <fuf@mageo.cz>, git@vger.kernel.org
Subject: Re: [PATCH] Don't use "<unknown>" for unknown values of placeholders and suppress printing of empty user formats.
Date: Tue, 25 Sep 2007 17:43:56 -0700	[thread overview]
Message-ID: <7vwsue1cj7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0709251543561.28395@racer.site> (Johannes Schindelin's message of "Tue, 25 Sep 2007 15:47:17 +0100 (BST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> This may have warranted a description in the commit message a la
>
> 	Instead of setting unknown entries to "<unknown>" in the 
> 	interp_table, we teach interpolate() to replace entries with 
> 	NULL values by the empty string.

Indeed.

> Here are still spaces instead of tabs.
>
> These are only minor details; I don't know if Junio wants to fix them 
> himself.

Good eyes.

Also a sign-off is missing ;-)

      reply	other threads:[~2007-09-26  0:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 14:38 [PATCH] Don't use "<unknown>" for unknown values of placeholders and suppress printing of empty user formats Michal Vitecek
2007-09-25 14:47 ` Johannes Schindelin
2007-09-26  0:43   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vwsue1cj7.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=fuf@mageo.cz \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.