From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: Peng Tao <bergwolf@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] fix git format-patch --cc=<email> format
Date: Sat, 28 Feb 2009 09:29:58 -0800 [thread overview]
Message-ID: <7vy6vqfp0p.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <76718490902280815if1c3fa7o790112b410d52224@mail.gmail.com> (Jay Soffian's message of "Sat, 28 Feb 2009 11:15:35 -0500")
Jay Soffian <jaysoffian@gmail.com> writes:
> On Sat, Feb 28, 2009 at 7:42 AM, Peng Tao <bergwolf@gmail.com> wrote:
>> If there are multiple --cc=<email> arguments, git format-patch will generate
>> patches with cc lines like:
>> Cc: <email>,
>> <email>
>> which git send-email fails to parse.
>> git send-email only accept formats like:
>> Cc: <email>
>> Cc: <email>
>> So change git format-patch to generate patches in a proper format.
>
> This is fixed in next, but we fixed send-email instead to handle the
> messages that format-patch generates, as they should be valid.
Per RFC2822 3.6 (pp 19-20), "cc" is to appear at most once (same is true
for "to" and "bcc"). I think fix to format-patch is necessary regardless
of what send-email does.
next prev parent reply other threads:[~2009-02-28 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-28 12:42 [PATCH] fix git format-patch --cc=<email> format Peng Tao
2009-02-28 16:15 ` Jay Soffian
2009-02-28 17:29 ` Junio C Hamano [this message]
2009-03-01 1:01 ` Jeff King
2009-03-01 2:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy6vqfp0p.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=bergwolf@gmail.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.