From: Junio C Hamano <gitster@pobox.com>
To: Yann Dirson <ydirson@altern.org>
Cc: "Nguy???n Thái Ng???c Duy" <pclouds@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] diffcore-rename: support rename cache
Date: Fri, 07 Nov 2008 15:17:54 -0800 [thread overview]
Message-ID: <7vy6zvdt25.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081107222128.GB4030@nan92-1-81-57-214-146.fbx.proxad.net> (Yann Dirson's message of "Fri, 7 Nov 2008 23:21:28 +0100")
Yann Dirson <ydirson@altern.org> writes:
> On Fri, Nov 07, 2008 at 09:35:32PM +0700, Nguy???n Thái Ng???c Duy wrote:
>> This patch teaches diffcore_rename() to look into
>> $GIT_DIR/rename-cache and make use of it to recreate diff_filepair.
>> With proper cache, there should be no available entry for estimation
>> after exact matching.
>
> This is something I have thought about in the past, good to see that
> implemented :)
>
>> Rename caching is per commit. I don't think abitrary tree-tree caching
>> is worth it.
>
> That could be a nice complement to my directory-rename patch.
Has anybody thought about interaction between that caching and pathspec
limited operation?
next prev parent reply other threads:[~2008-11-07 23:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 14:35 [PATCH 1/2] diffcore-rename: support rename cache Nguyễn Thái Ngọc Duy
2008-11-07 14:35 ` [PATCH 2/2] diffcore-rename: add config option to allow to cache renames Nguyễn Thái Ngọc Duy
2008-11-07 22:21 ` [PATCH 1/2] diffcore-rename: support rename cache Yann Dirson
2008-11-07 23:17 ` Junio C Hamano [this message]
2008-11-08 4:01 ` Nguyen Thai Ngoc Duy
2008-11-08 9:24 ` Yann Dirson
2008-11-08 9:29 ` Nguyen Thai Ngoc Duy
2008-11-08 11:47 ` Jeff King
2008-11-08 12:00 ` Nguyen Thai Ngoc Duy
2008-11-09 2:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy6zvdt25.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.