From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] bash completion: Improve responsiveness of git-log completion
Date: Sun, 13 Jul 2008 14:38:29 -0700 [thread overview]
Message-ID: <7vy745piqy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20080713023742.GA31760@spearce.org
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Junio noticed the bash completion has been taking a long time lately....
The credit actually goes to Ingo.
> Petr Baudis tracked it down to 72e5e989b ("bash: Add space after
> unique command name is completed."). Tracing the code showed
> we spent significant time inside of this loop within __gitcomp,
> due to the string copying overhead....
> ...
> Does this make things better? Or worse? I'm not seeing a huge
> difference on my own system. Maybe its too fast these days...
Ingo, I understand you have stopped using the completion long time ago due
to this latency issue. Together with d773c63 (bash: offer only paths
after '--', 2008-07-08) that already is in 'maint' and 'master', this
hopefully would make the completion usable for you again?
next prev parent reply other threads:[~2008-07-13 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-13 2:37 [PATCH] bash completion: Improve responsiveness of git-log completion Shawn O. Pearce
2008-07-13 4:02 ` Petr Baudis
2008-07-13 13:55 ` Johannes Schindelin
2008-07-13 21:38 ` Junio C Hamano [this message]
2008-07-13 22:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy745piqy.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pasky@suse.cz \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.