From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Provide git_config with a callback-data parameter
Date: Wed, 14 May 2008 18:52:55 -0700 [thread overview]
Message-ID: <7vy76cib9k.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0805150156230.30431@racer> (Johannes Schindelin's message of "Thu, 15 May 2008 02:02:45 +0100 (BST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> Great, as this has also been a pet-peeve of mine for quite some time.
>>
>> Except the patch has quite a many rejects X-<.
>
> Did you try to apply it to "next"?
The rejects are Ok. As long as function signature change of git_config()
is there, any misconversion will be caught by the compiler so I can manage
with relatively high confidence.
I need manual inspection on the other patch, as s/path.list/string.list/
could oversubstitute without breaking compilation.
prev parent reply other threads:[~2008-05-15 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 17:46 [PATCH 0/2] Fix two pet peeves of mine Johannes Schindelin
2008-05-14 17:46 ` [PATCH 1/2] Rename path_list to string_list Johannes Schindelin
2008-05-14 17:46 ` [PATCH 2/2] Provide git_config with a callback-data parameter Johannes Schindelin
2008-05-14 19:27 ` Junio C Hamano
2008-05-15 1:02 ` Johannes Schindelin
2008-05-15 1:52 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy76cib9k.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.