From: Junio C Hamano <gitster@pobox.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Andy Whitcroft <apw@shadowen.org>,
git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] shortlog: take the first populated line of the description
Date: Wed, 05 Mar 2008 13:27:21 -0800 [thread overview]
Message-ID: <7vy78wlv46.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LFD.1.00.0803051346200.2947@xanadu.home
Nicolas Pitre <nico@cam.org> writes:
> On Wed, 5 Mar 2008, Andy Whitcroft wrote:
> ...
>> ... I cannot think of any good reason not to take the first
>> populated line for a shortlog. The alternative less agressive
>> compromise might be to skip only completly empty lines at the
>> start, but I am not sure that adds any value.
>>
>> I seem to get a lot of these in converted SVN commits.
>>
>> Comments?
>
> Maybe it is the SVN conversion that needs fixing?
I thought about saying the same, but I am of two minds.
It is likely that you would want to clean-up when importing,
especially when you are planning to abandon the other system and
switch to git. But you may want to have an import that is as
close to the original as possible, excess blank lines in the log
messages and all.
I think Andy's fix to make the output side take away
unnecessary blank lines is unconditionally good.
I've added these three lines at the end of the log message.
This is often useful when dealing with commits imported from foreign SCMs
that do not tidy up the log message of useless blank lines at the
beginning.
next prev parent reply other threads:[~2008-03-05 21:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 14:24 [PATCH] shortlog: take the first populated line of the description Andy Whitcroft
2008-03-05 14:48 ` Johannes Schindelin
2008-03-05 16:43 ` Andy Whitcroft
2008-03-05 16:51 ` Johannes Schindelin
2008-03-05 18:47 ` Nicolas Pitre
2008-03-05 21:27 ` Junio C Hamano [this message]
2008-03-05 21:47 ` Nicolas Pitre
2008-03-05 22:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy78wlv46.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=apw@shadowen.org \
--cc=git@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.