From: Junio C Hamano <junkio@cox.net>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Remove shell dependency in env.c
Date: Thu, 15 Sep 2005 00:58:39 -0700 [thread overview]
Message-ID: <7vy85yahjk.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <43290BB8.90501@zytor.com> (H. Peter Anvin's message of "Wed, 14 Sep 2005 22:50:48 -0700")
"H. Peter Anvin" <hpa@zytor.com> writes:
> This patch adds an invocation of "env", so rsh.c works for C-shell users
> as well as Bourne shell users.
Hmph. I think the original code is buggy already. If the path
has a single quote in it, you would get into a problem. If the
remote end first interprets what is given to it with C-shell,
then it probably would also barf if path had a '!' in it, too,
even though we quote the entire thing within a single-quote
pair.
next prev parent reply other threads:[~2005-09-15 7:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-15 5:50 [PATCH] Remove shell dependency in env.c H. Peter Anvin
2005-09-15 7:58 ` Junio C Hamano [this message]
2005-09-15 16:30 ` H. Peter Anvin
2005-09-15 18:44 ` Shell quoting H. Peter Anvin
2005-09-15 19:01 ` Linus Torvalds
2005-09-15 19:31 ` H. Peter Anvin
2005-09-15 19:50 ` Junio C Hamano
2005-09-15 20:18 ` H. Peter Anvin
2005-09-15 19:35 ` Junio C Hamano
2005-09-15 20:02 ` Linus Torvalds
2005-09-16 19:20 ` Junio C Hamano
2005-09-15 19:33 ` [PATCH] rsh.c env and quoting cleanup, take 2 H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy85yahjk.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=hpa@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.