From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Matt McCutchen <matt@mattmccutchen.net>, git@vger.kernel.org
Subject: Re: [PATCH try 2] t1301-shared-repo.sh: don't let a default ACL interfere with the test
Date: Wed, 15 Oct 2008 22:23:20 -0700 [thread overview]
Message-ID: <7vzll5jepj.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <48F5A590.3050905@viscovery.net> (Johannes Sixt's message of "Wed, 15 Oct 2008 10:10:56 +0200")
Johannes Sixt <j.sixt@viscovery.net> writes:
> Junio C Hamano schrieb:
>
>> If that is the case what difference does your suggestion of not putting it
>> in test-lib.sh make? We discourage users from playing ACL games, and we
>> protect ourselves from such by making sure the trash directory used for
>> running tests are not contaminated with ACL. Wouldn't it make more sense
>> to do so for all the tests, so that future test writers do not have to
>> worry about it?
>
> We have to decide case by case. In the case of shared directories it makes
> sense to suggest "do not play ACL games". In other cases, however, this
> suggestion could not work out that well, and a workaround in the code is
> the better solutions. But we do not know what those other cases are, and
> the test suite may be a tool to uncover them.
Although I am not particularly interested in hypothetical case that does
not have concrete examples, I do not care deeply enough either. So let's
take this patch (with updated/corrected log message) that minimally covers
the parts that can be broken by ACL games.
next prev parent reply other threads:[~2008-10-16 5:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 22:07 [PATCH] t1301-shared-repo.sh: don't let a default ACL interfere with the test Matt McCutchen
2008-10-14 22:10 ` [PATCH try 2] " Matt McCutchen
2008-10-14 22:32 ` Junio C Hamano
2008-10-14 23:00 ` Matt McCutchen
2008-10-14 23:45 ` Deskin Miller
2008-10-15 6:13 ` Johannes Sixt
2008-10-15 6:30 ` Junio C Hamano
2008-10-15 7:18 ` Johannes Sixt
2008-10-15 7:57 ` Junio C Hamano
2008-10-15 8:10 ` Johannes Sixt
2008-10-16 5:23 ` Junio C Hamano [this message]
2008-10-17 2:28 ` Matt McCutchen
2008-10-17 4:30 ` Junio C Hamano
2008-10-17 4:33 ` Matt McCutchen
2008-10-17 2:28 ` [PATCH try 3] " Matt McCutchen
2008-10-17 2:32 ` [PATCH try 4] " Matt McCutchen
2008-10-15 14:34 ` [PATCH try 2] " Matt McCutchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzll5jepj.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=matt@mattmccutchen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.