From: Junio C Hamano <gitster@pobox.com>
To: "Avery Pennarun" <apenwarr@gmail.com>
Cc: "Git ML" <git@vger.kernel.org>
Subject: Re: [bug] Segfault in git rev-list --first-parent --bisect
Date: Fri, 22 Aug 2008 22:31:07 -0700 [thread overview]
Message-ID: <7vzln42t7o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7v7ia848aa.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Fri, 22 Aug 2008 22:20:13 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> "Avery Pennarun" <apenwarr@gmail.com> writes:
>
>> $ git rev-list --first-parent --bisect 5109c91 ^d798a2bfe094
>> Segmentation fault
>
> Totally untested, usefulness fairly unknown.
The latter part of this statement needs a bit of explanation. I do not
mean "--first-parent --bisect" is useless. What I meant is that the
approach is only catering to --first-parent and not about non-standard way
to limit the list such as --since, --max-count, etc.
The current bisection algorithm only pays attention to the pathspec based
history simplification and bottom..top (aka "UNINTERESTING or not"). A
proper fix to handle these cases should work inside do_find_bisection(),
and count_interesting_parents() instead of hiding the parents away that
first_parent traversal did not touch, like the patch I sent out.
prev parent reply other threads:[~2008-08-23 5:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 3:20 [bug] Segfault in git rev-list --first-parent --bisect Avery Pennarun
2008-08-23 4:51 ` Junio C Hamano
2008-08-23 5:20 ` Junio C Hamano
2008-08-23 5:31 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzln42t7o.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.