From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, krh@redhat.com, gitster@pobox.com
Subject: Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created
Date: Sun, 02 Dec 2007 23:33:28 -0800 [thread overview]
Message-ID: <7vzlwsmdvb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071201222106.GA27102@coredump.intra.peff.net> (Jeff King's message of "Sat, 1 Dec 2007 17:21:06 -0500")
Jeff King <peff@peff.net> writes:
> On Sun, Nov 11, 2007 at 05:36:52PM +0000, Johannes Schindelin wrote:
>
>> The function log_tree_commit() does not break the line, so we have to
>> do it ourselves.
>
> Johannes,
>
> Can you explain the rationale for this change in more detail?
>
> When I run builtin-commit from the tip of next, I always get an extra
> newline (as compared to the shell behavior):
After reverting this, recording a merge commit seems to have lost the
newline. Can be easily reproduced with:
$ git merge --no-commit some-branch
$ git commit -a -m 'foo'
next prev parent reply other threads:[~2007-12-03 7:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 17:35 [PATCH 0/6] Various (replacement) patches to builtin-commit Johannes Schindelin
2007-11-11 17:35 ` [PATCH 1/6] builtin-commit: fix author date with --amend --author=<author> Johannes Schindelin
2007-11-12 19:38 ` Kristian Høgsberg
2007-11-12 20:12 ` Johannes Schindelin
2007-11-13 0:37 ` Junio C Hamano
2007-11-11 17:35 ` [PATCH 2/6] git status: show relative paths when run in a subdirectory Johannes Schindelin
2007-11-11 17:35 ` [PATCH 3/6] builtin-commit: fix --signoff Johannes Schindelin
2007-11-11 17:36 ` [PATCH 4/6] builtin-commit --s: add a newline if the last line was no S-O-B Johannes Schindelin
2007-11-11 17:36 ` [PATCH 5/6] builtin-commit: resurrect behavior for multiple -m options Johannes Schindelin
2007-11-11 19:42 ` Pierre Habouzit
2007-11-11 20:42 ` Johannes Schindelin
2007-11-11 22:11 ` Pierre Habouzit
2007-11-11 22:13 ` Pierre Habouzit
2007-11-11 17:36 ` [PATCH 6/6] builtin-commit: Add newline when showing which commit was created Johannes Schindelin
2007-12-01 22:21 ` Jeff King
2007-12-01 22:41 ` Johannes Schindelin
2007-12-02 5:40 ` Jeff King
2007-12-02 12:13 ` Johannes Schindelin
2007-12-02 16:54 ` Jeff King
2007-12-02 17:18 ` Johannes Schindelin
2007-12-02 18:34 ` Junio C Hamano
2007-12-02 21:20 ` Johannes Schindelin
2007-12-03 7:33 ` Junio C Hamano [this message]
2007-12-03 7:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzlwsmdvb.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.