From: Junio C Hamano <junkio@cox.net>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH 1/2] Add a useful return value to git-check-attr
Date: Tue, 17 Apr 2007 02:28:34 -0700 [thread overview]
Message-ID: <7vzm57pcxp.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200704171010.49168.andyparkins@gmail.com> (Andy Parkins's message of "Tue, 17 Apr 2007 10:10:48 +0100")
Andy Parkins <andyparkins@gmail.com> writes:
> git-check-attr previously always returned success. With this patch it
> returns success when the requested attribute is found for all supplied
> paths.
>
> This lets you check in a script whether a file has an attribute:
>
> $ git-check-attr attribute -- file && echo "file has attribute"
I wrote check-attr primarily to have a quick way to make sure
the attribute stack is working properly, but I agree making
gitattributes available to scripts is important to make it
useful in general.
And your patch was a step in the right direction based on my
previous patch.
But sorry, you were shooting at a target that is still moving
too fast, and you missed. It's not your fault, as even I did
not know where it was heading to, but my plan has been to have
the scripts parse the text output, as we would need more than
true/false values, as I did in the four patch series I sent out
tonight.
next prev parent reply other threads:[~2007-04-17 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 9:10 [RFC/PATCH 1/2] Add a useful return value to git-check-attr Andy Parkins
2007-04-17 9:28 ` Junio C Hamano [this message]
2007-04-17 10:24 ` Andy Parkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzm57pcxp.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.