From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv6 0/7] Implement pmd hardware support exports Date: Tue, 07 Jun 2016 14:27:46 +0200 Message-ID: <8007794.NRYQLa1q3Z@xps13> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <5001673.vShpV6f8hz@xps13> <20160607120830.GB3903@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Panu Matilainen To: Neil Horman Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 5E5369AA2 for ; Tue, 7 Jun 2016 14:27:50 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id v199so17086650wmv.0 for ; Tue, 07 Jun 2016 05:27:50 -0700 (PDT) In-Reply-To: <20160607120830.GB3903@hmsreliant.think-freely.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-07 08:08, Neil Horman: > On Tue, Jun 07, 2016 at 11:34:56AM +0200, Thomas Monjalon wrote: > > Hi Neil, > > > > You are creating a new directory buildtools/ which depends on mk/ > I don't know what this means. Every part of the dpdk that builds code depends > on the infrastructure in mk/ (save for the scripts below) Yes, I'm just doing a summary of the build system. > > We also have some scripts used in the build process: > > scripts/auto-config-h.sh > > scripts/depdirs-rule.sh > > scripts/gen-build-mk.sh > > scripts/gen-config-h.sh > > scripts/relpath.sh > > I think we should move these scripts somewhere else, probably in mk. > > So we would have only 2 directories for the build system and we would > > keep the scripts directory only for dev tools. > > > > If we want to make a step further, we can rename scripts/ to devtools/ > > and tools/ to usertools/. > > > > Opinions? > > > I suppose if you like, sure, though I would caution against moving them to mk/ > as no one really expects executable scripts in the infrastructure makefile area. > If you want to move the buildtool scripts elsewhere I would suggest > buildtools/scripts. Yes that's what I thought first, but as stated above, buildtools depends on mk, and mk/ depends on these scripts. > Either way though, this movement seems to fall outside of the purview of the > purpose of the changeset associated with this email thread. Yes, just discussing for possible more changes.