From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFC2CA9EA0 for ; Tue, 22 Oct 2019 08:54:31 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1186120679 for ; Tue, 22 Oct 2019 08:54:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dgu+TC/p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1186120679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iMpvo-0005Oj-C5; Tue, 22 Oct 2019 08:54:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iMpvn-0005OY-5O for xen-devel@lists.xenproject.org; Tue, 22 Oct 2019 08:54:19 +0000 X-Inumbo-ID: 880129dc-f4a9-11e9-beca-bc764e2007e4 Received: from mail-wr1-x442.google.com (unknown [2a00:1450:4864:20::442]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 880129dc-f4a9-11e9-beca-bc764e2007e4; Tue, 22 Oct 2019 08:54:18 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id a11so984985wra.6 for ; Tue, 22 Oct 2019 01:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=V4VhBihoolZqFYIN54r9nmx9vYW/oQSJU4NMMDQk7As=; b=Dgu+TC/pYPvxFl322P5ZQxatcCTlZr9/Na3bgs3e7uOoeVESu2uvhuRLFlA7Vx7/JT /eva777fMJ8YfTgOGc73Mx0YxP01s6+hevrbvcCTqdpw/rTSEltteQbcZoXK4PmPIUBm cl1ypCckqOcn43h6toBhuentFcrt9KGnXUPqpaFPa4bW3E56B+6i3Tx8qAHh1iiETUX3 dGqXsu8Ew2uALCJSx4VFErFJJJcuSnDcWNuVe97h231nTAgZjz2TP8/8KWalCN6fqC// yNJAMz15ra9LHEt59Z0uirpJUswkt76MyYPG+hYLPwDY8SCBSYcr4fVQzU3aNLfA4uei GoKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=V4VhBihoolZqFYIN54r9nmx9vYW/oQSJU4NMMDQk7As=; b=Jn8/fBOba6e3S0iLGVZUZJqb5CWcEvFwonlwWHNP0EMK4qdhz30zc2KhwSPMFtt8Ja pLgXyVAoaLsNegohaFMRsX0cJxYaXrUpkb6BF12FthNgLnCj8vtaaAIEWE9Z9/RegC7/ ED84CwVM8QbWVTT57ve2kt6fC9hPu6ZmDsbDg5K0yi1fPanESMZlWiGoopzSv3kUr1Zt c7X+4TAPCjQCAS7SBqfz6aPYBhvVB5lvSWyqQbnvLEP9heD9RqgRTUjitgDuFwlQc1hR 1RDZk17Le4KnfVYOoQuCHbo+OnynS8KzfNUfy/7ONX/+T7TQzVUspS7qjHYyA65N4DfZ TA6w== X-Gm-Message-State: APjAAAXRACagEoY8oMtoYF76jSuEvd4LZwmff1fLLuadILD9AVv2dptW ZcJbw1foth/M84r1ulXfa4M= X-Google-Smtp-Source: APXvYqz8BBP5wYK70GC9RnObS4GNK085VbmK6595Ok53rEH80UBeoYuODXHUVHqO1KEoZ2xkh46u7g== X-Received: by 2002:a5d:6b0a:: with SMTP id v10mr2269042wrw.32.1571734457519; Tue, 22 Oct 2019 01:54:17 -0700 (PDT) Received: from ?IPv6:2a01:c23:604c:2a00:af2b:2e92:39f9:c05b? ([2a01:c23:604c:2a00:af2b:2e92:39f9:c05b]) by smtp.gmail.com with ESMTPSA id p21sm8365131wmc.25.2019.10.22.01.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 01:54:17 -0700 (PDT) Message-ID: <80119c423b25ff027844fd04a4e57e5fcb7dfbb9.camel@gmail.com> From: Esteban Bosse To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , qemu-devel@nongnu.org Date: Tue, 22 Oct 2019 10:50:46 +0200 In-Reply-To: <20191018134754.16362-5-philmd@redhat.com> References: <20191018134754.16362-1-philmd@redhat.com> <20191018134754.16362-5-philmd@redhat.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()" X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Stefano Stabellini , xen-devel@lists.xenproject.org, Paul Durrant , "Michael S. Tsirkin" , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9?= Poussineau , Aleksandar Markovic , Igor Mammedov , Anthony Perard , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno , Richard Henderson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" RWwgdmllLCAxOC0xMC0yMDE5IGEgbGFzIDE1OjQ3ICswMjAwLCBQaGlsaXBwZSBNYXRoaWV1LURh dWTDqSBlc2NyaWJpw7M6Cj4gRnJvbTogUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPGY0YnVnQGFt c2F0Lm9yZz4KPiAKPiBUaGlzIGZ1bmN0aW9uIGlzbid0IHVzZWQgYW55bW9yZS4KPiAKPiBUaGlz IHJldmVydHMgY29tbWl0IDIyZWMzMjgzZWZiYTliYTA3OTI3OTBkYTc4NmQ2Nzc2ZDgzZjJhOTIu Cj4gCj4gUmV2aWV3ZWQtYnk6IFRob21hcyBIdXRoIDx0aHV0aEByZWRoYXQuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxmNGJ1Z0BhbXNhdC5vcmc+Cj4gLS0t Cj4gIGh3L2NvcmUvaXJxLmMgICAgfCAxNCAtLS0tLS0tLS0tLS0tLQo+ICBpbmNsdWRlL2h3L2ly cS5oIHwgIDUgLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxOSBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvaHcvY29yZS9pcnEuYyBiL2h3L2NvcmUvaXJxLmMKPiBpbmRleCA3Y2MwMjk1 ZDBlLi5mYjMwNDViOTEyIDEwMDY0NAo+IC0tLSBhL2h3L2NvcmUvaXJxLmMKPiArKysgYi9ody9j b3JlL2lycS5jCj4gQEAgLTEyMCwyMCArMTIwLDYgQEAgcWVtdV9pcnEgcWVtdV9pcnFfc3BsaXQo cWVtdV9pcnEgaXJxMSwgcWVtdV9pcnEKPiBpcnEyKQo+ICAgICAgcmV0dXJuIHFlbXVfYWxsb2Nh dGVfaXJxKHFlbXVfc3BsaXRpcnEsIHMsIDApOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBwcm94 eV9pcnFfaGFuZGxlcih2b2lkICpvcGFxdWUsIGludCBuLCBpbnQgbGV2ZWwpCj4gLXsKPiAtICAg IHFlbXVfaXJxICoqdGFyZ2V0ID0gb3BhcXVlOwo+IC0KPiAtICAgIGlmICgqdGFyZ2V0KSB7Cj4g LSAgICAgICAgcWVtdV9zZXRfaXJxKCgqdGFyZ2V0KVtuXSwgbGV2ZWwpOwo+IC0gICAgfQo+IC19 Cj4gLQo+IC1xZW11X2lycSAqcWVtdV9pcnFfcHJveHkocWVtdV9pcnEgKip0YXJnZXQsIGludCBu KQo+IC17Cj4gLSAgICByZXR1cm4gcWVtdV9hbGxvY2F0ZV9pcnFzKHByb3h5X2lycV9oYW5kbGVy LCB0YXJnZXQsIG4pOwo+IC19Cj4gLQo+ICB2b2lkIHFlbXVfaXJxX2ludGVyY2VwdF9pbihxZW11 X2lycSAqZ3Bpb19pbiwgcWVtdV9pcnFfaGFuZGxlcgo+IGhhbmRsZXIsIGludCBuKQo+ICB7Cj4g ICAgICBpbnQgaTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ody9pcnEuaCBiL2luY2x1ZGUvaHcv aXJxLmgKPiBpbmRleCBmZTUyN2Y2ZjUxLi4yNGJhMGVjZTExIDEwMDY0NAo+IC0tLSBhL2luY2x1 ZGUvaHcvaXJxLmgKPiArKysgYi9pbmNsdWRlL2h3L2lycS5oCj4gQEAgLTUxLDExICs1MSw2IEBA IHFlbXVfaXJxIHFlbXVfaXJxX2ludmVydChxZW11X2lycSBpcnEpOwo+ICAgKi8KPiAgcWVtdV9p cnEgcWVtdV9pcnFfc3BsaXQocWVtdV9pcnEgaXJxMSwgcWVtdV9pcnEgaXJxMik7Cj4gIAo+IC0v KiBSZXR1cm5zIGEgbmV3IElSUSBzZXQgd2hpY2ggY29ubmVjdHMgMToxIHRvIGFub3RoZXIgSVJR IHNldCwKPiB3aGljaAo+IC0gKiBtYXkgYmUgc2V0IGxhdGVyLgo+IC0gKi8KPiAtcWVtdV9pcnEg KnFlbXVfaXJxX3Byb3h5KHFlbXVfaXJxICoqdGFyZ2V0LCBpbnQgbik7Cj4gLQo+ICAvKiBGb3Ig aW50ZXJuYWwgdXNlIGluIHF0ZXN0LiAgU2ltaWxhciB0byBxZW11X2lycV9zcGxpdCwgYnV0Cj4g b3BlcmF0aW5nCj4gICAgIG9uIGFuIGV4aXN0aW5nIHZlY3RvciBvZiBxZW11X2lycS4gICovCj4g IHZvaWQgcWVtdV9pcnFfaW50ZXJjZXB0X2luKHFlbXVfaXJxICpncGlvX2luLCBxZW11X2lycV9o YW5kbGVyCj4gaGFuZGxlciwgaW50IG4pOwpSZXZpZXdlZC1ieTogRXN0ZWJhbiBCb3NzZSA8ZXN0 ZWJhbmJvc3NlQGdtYWlsLmNvbT4KCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v eGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78754CA9EB9 for ; Tue, 22 Oct 2019 08:55:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4726720679 for ; Tue, 22 Oct 2019 08:55:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dgu+TC/p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4726720679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMpwZ-00061V-Ha for qemu-devel@archiver.kernel.org; Tue, 22 Oct 2019 04:55:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49667) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMpvo-0005AA-Cv for qemu-devel@nongnu.org; Tue, 22 Oct 2019 04:54:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMpvn-0006vS-8N for qemu-devel@nongnu.org; Tue, 22 Oct 2019 04:54:20 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:33785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMpvn-0006v3-2T for qemu-devel@nongnu.org; Tue, 22 Oct 2019 04:54:19 -0400 Received: by mail-wr1-x441.google.com with SMTP id s1so8314711wro.0 for ; Tue, 22 Oct 2019 01:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=V4VhBihoolZqFYIN54r9nmx9vYW/oQSJU4NMMDQk7As=; b=Dgu+TC/pYPvxFl322P5ZQxatcCTlZr9/Na3bgs3e7uOoeVESu2uvhuRLFlA7Vx7/JT /eva777fMJ8YfTgOGc73Mx0YxP01s6+hevrbvcCTqdpw/rTSEltteQbcZoXK4PmPIUBm cl1ypCckqOcn43h6toBhuentFcrt9KGnXUPqpaFPa4bW3E56B+6i3Tx8qAHh1iiETUX3 dGqXsu8Ew2uALCJSx4VFErFJJJcuSnDcWNuVe97h231nTAgZjz2TP8/8KWalCN6fqC// yNJAMz15ra9LHEt59Z0uirpJUswkt76MyYPG+hYLPwDY8SCBSYcr4fVQzU3aNLfA4uei GoKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=V4VhBihoolZqFYIN54r9nmx9vYW/oQSJU4NMMDQk7As=; b=jchSzmO0xAlxcHp5n7+amjlAyIFcYgRZXiyptNoJZd4WnbmiTk+MqtPaMi6bYycvq5 9iVTqYXmHYv2utSR3kG/CAtbrona5uBRACCDiEAUbJoeCyWhUUExb9kp4eSRvoq3hw6y Sr7dhqwj6VzqTxSFyev7Xm4bxrpmuD0aLs8C7Ilgb1MLx/pzojkhrZsGLGZl0Y2wsMw3 uoXtnJuy2sdYqTudmByXOM4jJD3X53lJ3QRaC9gV8qTGIP8mveqGPR47RXCnesQ90ZqG UDIBna5vcJFs4a5wITjTc3rM7WT8DOwx1zZN2wIPVbr3LAF2n5B+A+AGuseE/hurPw0K 0IMA== X-Gm-Message-State: APjAAAUGbjjgGz1arpoDoGEHPof0fTsYilpzaijpMns7NQqN0+BUMWxi hd9oZrukynUu1WUqKyYBefE= X-Google-Smtp-Source: APXvYqz8BBP5wYK70GC9RnObS4GNK085VbmK6595Ok53rEH80UBeoYuODXHUVHqO1KEoZ2xkh46u7g== X-Received: by 2002:a5d:6b0a:: with SMTP id v10mr2269042wrw.32.1571734457519; Tue, 22 Oct 2019 01:54:17 -0700 (PDT) Received: from ?IPv6:2a01:c23:604c:2a00:af2b:2e92:39f9:c05b? ([2a01:c23:604c:2a00:af2b:2e92:39f9:c05b]) by smtp.gmail.com with ESMTPSA id p21sm8365131wmc.25.2019.10.22.01.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 01:54:17 -0700 (PDT) Message-ID: <80119c423b25ff027844fd04a4e57e5fcb7dfbb9.camel@gmail.com> Subject: Re: [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()" From: Esteban Bosse To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , qemu-devel@nongnu.org Date: Tue, 22 Oct 2019 10:50:46 +0200 In-Reply-To: <20191018134754.16362-5-philmd@redhat.com> References: <20191018134754.16362-1-philmd@redhat.com> <20191018134754.16362-5-philmd@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Stefano Stabellini , xen-devel@lists.xenproject.org, Paul Durrant , "Michael S. Tsirkin" , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Eduardo Habkost , =?ISO-8859-1?Q?Herv=E9?= Poussineau , Aleksandar Markovic , Igor Mammedov , Anthony Perard , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Philippe Mathieu-Daudé > > This function isn't used anymore. > > This reverts commit 22ec3283efba9ba0792790da786d6776d83f2a92. > > Reviewed-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/core/irq.c | 14 -------------- > include/hw/irq.h | 5 ----- > 2 files changed, 19 deletions(-) > > diff --git a/hw/core/irq.c b/hw/core/irq.c > index 7cc0295d0e..fb3045b912 100644 > --- a/hw/core/irq.c > +++ b/hw/core/irq.c > @@ -120,20 +120,6 @@ qemu_irq qemu_irq_split(qemu_irq irq1, qemu_irq > irq2) > return qemu_allocate_irq(qemu_splitirq, s, 0); > } > > -static void proxy_irq_handler(void *opaque, int n, int level) > -{ > - qemu_irq **target = opaque; > - > - if (*target) { > - qemu_set_irq((*target)[n], level); > - } > -} > - > -qemu_irq *qemu_irq_proxy(qemu_irq **target, int n) > -{ > - return qemu_allocate_irqs(proxy_irq_handler, target, n); > -} > - > void qemu_irq_intercept_in(qemu_irq *gpio_in, qemu_irq_handler > handler, int n) > { > int i; > diff --git a/include/hw/irq.h b/include/hw/irq.h > index fe527f6f51..24ba0ece11 100644 > --- a/include/hw/irq.h > +++ b/include/hw/irq.h > @@ -51,11 +51,6 @@ qemu_irq qemu_irq_invert(qemu_irq irq); > */ > qemu_irq qemu_irq_split(qemu_irq irq1, qemu_irq irq2); > > -/* Returns a new IRQ set which connects 1:1 to another IRQ set, > which > - * may be set later. > - */ > -qemu_irq *qemu_irq_proxy(qemu_irq **target, int n); > - > /* For internal use in qtest. Similar to qemu_irq_split, but > operating > on an existing vector of qemu_irq. */ > void qemu_irq_intercept_in(qemu_irq *gpio_in, qemu_irq_handler > handler, int n); Reviewed-by: Esteban Bosse