From: Evgeniy Polyakov <zbr@ioremap.net>
To: Jan Kandziora <jjj@gmx.de>, Wolfram Sang <wsa@the-dreams.de>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge
Date: Sat, 23 Jul 2016 07:44:57 +0300 [thread overview]
Message-ID: <80161469249097@web5m.yandex.ru> (raw)
In-Reply-To: <578FC09D.8040706@gmx.de>
20.07.2016, 21:19, "Jan Kandziora" <jjj@gmx.de>:
> Am 20.07.2016 um 19:34 schrieb Evgeniy Polyakov:
>> Is that a hardware limitation that there is no interrupt or other
>> completion mechanism which would handle this case?
>
> Ah, forgot to address that question.
>
> The DS28E17 has a BUSY pin. We could add an interrupt-driven busy
> mechanism but the mechanism without the interrupt line has to stay in
> there because most people wouldn't add an interrupt line to their
> Onewire installation just for having that.
Ok, I see, its just a hardware issue which requires to have this potentially unhealthy busy loop.
Both patches look good to me, thank you.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2016-07-23 4:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 20:15 [PATCH 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge Jan Kandziora
2016-07-20 17:34 ` Evgeniy Polyakov
2016-07-20 18:01 ` Jan Kandziora
2016-07-20 18:19 ` Jan Kandziora
2016-07-23 4:44 ` Evgeniy Polyakov [this message]
2016-07-21 7:02 ` Wolfram Sang
2016-07-22 20:52 ` Jan Kandziora
2016-07-22 20:56 ` Jan Kandziora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80161469249097@web5m.yandex.ru \
--to=zbr@ioremap.net \
--cc=jjj@gmx.de \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.