All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: Ping-Ke Shih <pkshih@realtek.com>,
	Zeshan Ahmed Nobin <zeshanahmednobin@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Kalle Valo <kvalo@kernel.org>
Subject: RE: [PATCH rtw-next v3 2/2] wifi: rtw88: 8822c: ignore nrx values without CCK PD registers
Date: Tue, 17 Nov 2026 14:17:46 +0100	[thread overview]
Message-ID: <8023529A-60D3-4708-9772-027436BF7756@linux.dev> (raw)
In-Reply-To: <427f6f2e79474058958c3f3d0901df38@realtek.com>

Hi Ping-Ke,

Thanks for looking at this. I would just like to add something.

On November 17, 2026 7:38:21 AM GMT+01:00, Ping-Ke Shih
<pkshih@realtek.com> wrote:

[ ... ]

> Since this only can happen when a device is removed suddenly, how about
> reverting patch 1, and also validate bw <= RTW_CHANNEL_WIDTH_40 here.

As far as I can see, rtw_set_channel() stores the bandwidth in hal and
passes the same value to the chip's set_channel callback. We already
use hal.current_band_width when setting TX power.

CCK PD already checks hal.current_band_type and only runs on 2.4 GHz,
where the bandwidth is 20 or 40 MHz. So I think using the stored value
here is reasonable too. It avoids another register read and keeps a
failed read from becoming the bandwidth index.

Would you be okay with keeping patch 1 and using nrx > RF_PATH_B in
patch 2, as you suggested?

Best regards,
Luka Gejak

  reply	other threads:[~2026-11-17 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 20:18 [PATCH rtw-next v3 0/2] wifi: rtw88: 8822c: fix cck_pd_set when the chip stops responding Zeshan Ahmed Nobin
2026-11-15 20:18 ` [PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: fix out-of-bounds access in cck_pd_set Zeshan Ahmed Nobin
2026-11-16 14:49   ` Luka Gejak
2026-11-15 20:18 ` [PATCH rtw-next v3 2/2] wifi: rtw88: 8822c: ignore nrx values without CCK PD registers Zeshan Ahmed Nobin
2026-11-17  6:38   ` Ping-Ke Shih
2026-11-17 13:17     ` Luka Gejak [this message]
2026-11-18  0:25       ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8023529A-60D3-4708-9772-027436BF7756@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=zeshanahmednobin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.