From: George Dunlap <george.dunlap@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: george.dunlap@eu.citrix.com
Subject: [PATCH 3 of 3 v3] libxl: Warn that /usr/bin/pygrub is deprecated
Date: Tue, 15 May 2012 15:22:56 +0100 [thread overview]
Message-ID: <804eb2962984402ae58f.1337091776@kodo2> (raw)
In-Reply-To: <patchbomb.1337091773@kodo2>
v2: Use strcmp rather than strncmp.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
diff -r 9ebf2c1292c3 -r 804eb2962984 tools/libxl/libxl_bootloader.c
--- a/tools/libxl/libxl_bootloader.c Tue May 15 15:13:45 2012 +0100
+++ b/tools/libxl/libxl_bootloader.c Tue May 15 15:13:45 2012 +0100
@@ -338,6 +338,10 @@ void libxl__bootloader_run(libxl__egc *e
LOG(DEBUG, "Config bootloader value: %s", info->u.pv.bootloader);
+ if ( !strcmp(info->u.pv.bootloader, "/usr/bin/pygrub") )
+ LOG(WARN, "bootloader='/usr/bin/pygrub' is deprecated; use " \
+ "bootloader='pygrub' instead");
+
/* If the full path is not specified, check in the libexec path */
if ( info->u.pv.bootloader[0] != '/' ) {
char *bootloader;
next prev parent reply other threads:[~2012-05-15 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 14:22 [PATCH 0 of 3 v3] tools: Move bootloaders to libexec directory George Dunlap
2012-05-15 14:22 ` [PATCH 1 of 3 v3] libxl: Look for bootloader in libexec path George Dunlap
2012-05-15 14:22 ` [PATCH 2 of 3 v3] tools: Install pv bootloaders in libexec rather than /usr/bin George Dunlap
2012-05-15 14:22 ` George Dunlap [this message]
2012-05-15 15:29 ` [PATCH 0 of 3 v3] tools: Move bootloaders to libexec directory Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=804eb2962984402ae58f.1337091776@kodo2 \
--to=george.dunlap@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.