From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A21F5243962 for ; Sat, 8 Feb 2025 20:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739048319; cv=fail; b=CrsITpj+up2HQcjQ8orClVo5uX3Cwvns71wvto94uV6AAx87LJ4wltr2ShR8HcyihghBl0rED8ADniZNjgwoM6da0sS/i6EtHhrlmNUd379Mu6MOmN8tfIxLXmBAHXr+T3/eSTUVutnt5JYTCXIL05c70eE0PJpN0/PhU40j6fc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739048319; c=relaxed/simple; bh=Roh+bdiLnwkP5Z7jNK0pUc9ve04ZdHEfd94FIYTnTYE=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=IHMM7US9vBIsjNJ6/OxunzfOGFadxCRLnRcOgS0w933OVyEjCxmDv99gR2MGg9EmihT8GrJzJghFJl40YCEDcVJqNYuvAds4A41qdFZAr0cEIakN49MeZOs0J11khw8gz8vy0PlH9Xjup5WAziVmfe/Fi2qABHBANH74ifFS+W0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=LP0W1Xv8; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=SnonwLAk; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="LP0W1Xv8"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="SnonwLAk" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 518JhKY0006343; Sat, 8 Feb 2025 20:58:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=wEmJkulU2fGdTdpGaJpR6P6PjngKgUC1Qy3lP7FsycQ=; b= LP0W1Xv8fDfJETF5dPWQu7EKOoy/MzweX/oNXzE3AK9AuO6/yeEHu6xAZJ1yRrka YoQ5yESpQ3uNLHbHpghQ4ausDx0Mv2aFyJU7W7kYbeSrP3EatDDP5oialFK/809g lyf0O6pwBNRYeo+NqPbkYhVwOF9CyYyzp6U2Cv97z9d6BKU0zmiUF63iBpNEtRpi YzJzuwbf5TAWxOivi+eaNzZ07v2VfYz4Cv3Cw8Vwl3hFF+mIS7Iio+cv/F7rmJxa gWisUuwb2kRMQmjyiul4HYQwtzLMqVDNS/orx05rGbKHkQkI7lmNx9ZEUhmCgpuF HJTGLUYaOqS6aNmU+I8ltw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44p0qa8g9c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 Feb 2025 20:58:33 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 518Kocra018504; Sat, 8 Feb 2025 20:58:32 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2041.outbound.protection.outlook.com [104.47.66.41]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44nwqc9f14-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 08 Feb 2025 20:58:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XoV+c/r4E6Hw9Vhk7WKqWhAgbuV37DjCTZdzNklQy8Up+NXF5+6YiQAkBqTQcBk3nQ3AXphHaImEEYY82cu0przl0QXvFH8fEcnjJHnmrR8u2eFqoA+jkUkuNq9jtU8juq0ouZdDOYTYcfUa4aUcedDoVnW/VOg0zSEccqgzuRaDbyc4CVWbDY/noyFa23L49pkZvwi+GKLIS9Q65opuMr7pv3Sjf30yecNP0CvMUph0C8wmLFEpbR8K3nOWtDru5SHadsxQm4wUV/bj7ULv+XmrRvWRwCd/l+ITtQxf26+1fY3qQSu4ei7/d4oDsFwu49s85onh6BU2bYS21up2bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wEmJkulU2fGdTdpGaJpR6P6PjngKgUC1Qy3lP7FsycQ=; b=QiSMtjrdABvQIVh6emk94+gWpDq6mTNmp/P7nZYneoYqMkA4sNLqHVvr2FkkMGBrUT9KahpqqmAaK+mk05uLmCGPvDhepnCuVUfmxBvz4N1AbUe5V5Gpx1WFiudUXfXL0X2SFgdVJY8f7Td0Kc+6u1j7yW0n02StDXm65RGKyex6uWeCCtm61rYhfFmLJq3nzLzyzJh2G5Giie6aGJ8VCefgQ32JpVCuascytH5g8UV1ZrduhYppc+owdmGWaWcKhQl3WB9PSQj7bH96yuPzWvqtVK28c+cl59Zxd1RJgBptrvvPyi+9IC0uPZsGI14fzDfAibCx6cYgTm7hM1h+vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wEmJkulU2fGdTdpGaJpR6P6PjngKgUC1Qy3lP7FsycQ=; b=SnonwLAkcwcBOfvkOPc665sHNHbeWaRQmQui87dSefKkU23wbbkz2Jw3gkk0y873x82Cj/qh/I3K1EdSwjLpkqjOL2lKuIV19llSXljgCQtzPxnFwnfxDKiBRrdOKBrOZHGm/p3u5Bl809sKw8dE8NjxnvnDwLkvS2aSxVp9AOA= Received: from BN0PR10MB5128.namprd10.prod.outlook.com (2603:10b6:408:117::24) by CH3PR10MB7138.namprd10.prod.outlook.com (2603:10b6:610:122::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.14; Sat, 8 Feb 2025 20:58:30 +0000 Received: from BN0PR10MB5128.namprd10.prod.outlook.com ([fe80::743a:3154:40da:cf90]) by BN0PR10MB5128.namprd10.prod.outlook.com ([fe80::743a:3154:40da:cf90%6]) with mapi id 15.20.8422.012; Sat, 8 Feb 2025 20:58:30 +0000 Message-ID: <8065e515-9258-4ed4-a224-e30e0195c483@oracle.com> Date: Sat, 8 Feb 2025 15:58:28 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] bringup: Use full path when creating custom_source file To: Daniel Gomez Cc: Luis Chamberlain , Daniel Gomez , Joel Granados , kdevops@lists.linux.dev References: <20250205-jag-bringup_fixes-v2-1-48f70c0d0a08@kernel.org> <20250205101854.wgzqf2rc6cqk3xlc@AALNPWDAGOMEZ1.aal.scsc.local> <856b5fc0-7347-4c9f-8219-2cd983c27b7f@oracle.com> Content-Language: en-US From: Chuck Lever In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH0P220CA0015.NAMP220.PROD.OUTLOOK.COM (2603:10b6:610:ef::35) To BN0PR10MB5128.namprd10.prod.outlook.com (2603:10b6:408:117::24) Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN0PR10MB5128:EE_|CH3PR10MB7138:EE_ X-MS-Office365-Filtering-Correlation-Id: 855ca1c5-d369-4e98-4545-08dd48835750 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K2ZwT3dmdnovL3ZJTUluVE1Rb2dHZk5GUi9DNkhHRmZHcDJ1eFdKY0VCbTJJ?= =?utf-8?B?SmdDdkx4RDdwYm9WdGYxSGFrbitNRjVnaW51WWVVVlAwMGtQcmtJQkVORzVk?= =?utf-8?B?K05pNm12TGVnM2ExcDRPSWRON09mSVlxb0ZxRGt4UU9xcEVyRnhEa3R3bVVK?= =?utf-8?B?Q3kvU2NaNGd2SmtqL0ZCcFBudGgrczltNFhZdTlyUFVJeUZSZ0lCQzh6YnhV?= =?utf-8?B?ZysvbFYzUVcwT3ZyNnFxNzJ2a3N3aXJBOTdPWkFiRUlzbW9LdGxVNnhBeW9q?= =?utf-8?B?cXF0aFdNUUx0MmhZay9jZFNvS0JZZ2xOTE9BK2hqSjJRR2RkWmFvVTZ1UlR3?= =?utf-8?B?eTV6cHZJbGduSEJQY0Q1YkhzTWhnT24wY0FTcjVRaHZhdXBTanJOK1dxRlVZ?= =?utf-8?B?bTV5aGsvNW16emhTS3lub3RkdnBqTnB1VEhBN1dUaVFqWnhSNkhMeTZPaHZW?= =?utf-8?B?bDBtSzZGRzcvK2hxL0RHVTY4RTFYS2QyVVFReFJwNjlSSDJuQUMzcjZ1ajdI?= =?utf-8?B?ZHdWSStocWp4S21ZcjFEYW9xa25jcnhqcHBsaTRyYlRjVWsrQWdEanJ0c2Ew?= =?utf-8?B?cFgyU2lqMTl2NXA1VXRzTDRRTUhpWUV0NWx1TVB2bUM0dHRSdWk1eGowazJ6?= =?utf-8?B?bCtSSEIzV1pTNjlaOTZLanBHOGJFc3RXbGlBSGhSeHR2VjhITUxYTFoxa29J?= =?utf-8?B?cVU4bHhPUzFZM3p4RThPQ0hGaWFoQUJoUGRIOXRURzJaTzRqTnBoYTM1R3NP?= =?utf-8?B?ZG5IYjFvVnpGa3JZTk1aSHorbHlSUnRXUkdMT0lqaXIxRG8xRDNSYXFpZ2JJ?= =?utf-8?B?SWdRWGlGeWNqS3hESkVseGxJNlVacTdQdStzQlBQellLOVJPdm4vWVgvcmI2?= =?utf-8?B?Z2JKYnVvU2d1bHdQMndmUFBkNGV6aXhrTkcveDJseWVuUmRLZ2VWcFhCOW1k?= =?utf-8?B?WDZKTDlzTENGSjl5QzNEMHlaTlRIcDB6SEVDUXhXeUtRbWVKYktBZFUxYkNy?= =?utf-8?B?WC9ZMHMvVnFOREF5OUY3dm5EYzRnM25UZElObE9ualFsLzRKejFnc1BMcEVW?= =?utf-8?B?d3Z1bkhnOGljU0wySWQ3UnpKdWg1V1dpRkdxeCs5WDlYKzkwaHRMR2pkL0N3?= =?utf-8?B?TkFZclRjbDhGTlVqR1RlSWV1U0pvQWQzdFdaUW1FcTQ1eUIwT29lNDBWZFkr?= =?utf-8?B?citvclAySEFXdHRKWTNXbGxFdXRLMEgyUW45YTFiSC9nYUJWMktpWTBEZTk4?= =?utf-8?B?Q1pRQ0w4OXpteGo3WEh4Y0ZhbUh0VnBwdllDbXl4bXpMVXp5cmZ1OGlkYzZD?= =?utf-8?B?MTBLV2RsN1VlUnhKTGtUWnVsT3RzVmJIUVRoSVRXdkFEbDliTGtmK2VudllM?= =?utf-8?B?WW1jcWE0UmRsWXN2dGtXZUptdWZPNXZ2NGFxZHJhT3lDcHlvU3ZhMXI5azIy?= =?utf-8?B?bEFvSDd2UzcwNk9MRTc2MWJRK2NVd0Z1VWFlcFRiMU9Gbmpwemc5dEhOVnV3?= =?utf-8?B?L1ZvbGRGR2lneXhlNTZxVkQ0N0hHSm5xd0VvZVVHaEZFeDE3K0NkOTU2R2Jh?= =?utf-8?B?aG90RHVwT1dwVHBURHgyLzQyOW5KTEpaVjk1QzdaMnh0OTNHWmFMdXNEeTNV?= =?utf-8?B?eThOTWVZN3A1ZnV0VVlKTURqb240UGdYaDh6MDVZUE9qV2djTC9TSVM5NW1N?= =?utf-8?B?QmJVeE1SWmZrNEc5RDVkYzNsTnFSN0VOakRMVi9jRkhnOGZJNWwxNFpxdklo?= =?utf-8?B?UVZ0aGdiZDhON1o3MTl2a3llOTF6YngwVlZCWGlVbFpIR25vOWZVcXYxTXI2?= =?utf-8?B?ZTFLbTNZcnFJdFRoQnI4UT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0PR10MB5128.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFBRMGlmblRVVE1OVlEva1dSc1g3ZTEvRGMrNFRWWmNyTXVpbHFsY2ZKU3NI?= =?utf-8?B?MWx3YlBkZXEyZUw5ZWlIalVaSFovQ2hNR0FwWGhrb1NzYkFzamhzMlNIUUN5?= =?utf-8?B?SkNXeDY3M3NPbk1EMm1ES0ZZa2F6Z0pua0FaWG5WanBHeU54SlkyektiK2ow?= =?utf-8?B?dDdLVk9ocDdrUnRmdWFYM1NPRzFLREY5Nk1TWVMrRG9UMXZ5WTE3TEtGRkZX?= =?utf-8?B?cFJ4ZHN2U3VkS1A4ZWpKckFoTEtGSDNCRTRHK2t6QTdhcDlIbk9IWnRzdUd1?= =?utf-8?B?YkdXQVFPOFkzMklCVzZLVC9GWDdrdTFTbGRvUnBCTlkwUmlodkdTZU9iYzdt?= =?utf-8?B?ei9jM3lkVXMydWJFRDl3UmpzL0g1T0tUcGV3UWk5TWt5MmR2QTlWSlFjOU16?= =?utf-8?B?UENEeTlhSWIxUTM0MEZzSFRJR3lJaHZKWUJuR3dKbVA4ODc5TWs0Zy9JWDhw?= =?utf-8?B?WkxGUVJZakhLdTJyRFJwbUNjaXdxY1JrcEx6c0F2VFpBaG1rWnA3MGxjL3kw?= =?utf-8?B?czM2WDF5TkdtckFyckdpcUQvMnhTeEl5UVRIZ01XbW9hRUhIR01PL1pIUkJ5?= =?utf-8?B?aWJCbWQ1QXpKbWRCQ2FGZUk3UExnL0RmdmFpZGxqZ2ErdG83YThQeElId0Vz?= =?utf-8?B?cVhISzRIKzlnOUdOZEU0VUlVQllzZkV4TTNrYW1LMll4cEV3dUhCRi90eG9u?= =?utf-8?B?ZlNITjRoTWZmK1N4a1g3VGd4RFc0d21DdFdMZEZUZS9ldmtlOUJST3ByWnI0?= =?utf-8?B?elRkMytaMVFTZnUzcnE4MXZoUEczR1Myb2JCMC9CMUZJUWVzNDhlb1lDUmkr?= =?utf-8?B?MVlyQWhqSGRkNHI2dUJPdEZFMDZNRXpQNldNK25VWVJJRTB3M3hGUlhWTTd2?= =?utf-8?B?cTh5WTZGTEpiak4zVXVVMi84UGt0S0VxbmN3RHQ1MzQ2VFA3TVdVcy9VaHNz?= =?utf-8?B?L3NuM3Y3dUtUbmZlRFNlcDMrNHVVVm9WNmc4SkZQbWJubFN5V3cxUnZjcXJh?= =?utf-8?B?c0h2eDVKaDhtL3cvL0hiV014OHJRZjg4Z3NEdThxZTlzWjI1ZzZrZi9vZG5a?= =?utf-8?B?QXdWMGN1USsrVnMzdTZ0MlVBdDlTYStzVDFnZ1FQT1JzaHRleUdMSE1xZm4z?= =?utf-8?B?NXROUkpHaEoxZlJGUnovNXhNSW9kODluTmc1elVWejlBNEVBQkMyUThqYVV5?= =?utf-8?B?bXVmNlRhS1NKblU3S2Q2R1NUQzFVdlVmVk5uaUJLdkpISUFZaXFsSnpnVE9t?= =?utf-8?B?dlNNV1l1UjN2YVVJQmFxYUsvTFJneWFwNDlZV1NOankySHdYT2QrMURCNUMw?= =?utf-8?B?ZTFqY3lUZzU5UkdpSENEaE8veXlVd3ZhOVZWWTU5S1NQemZlUTY0ck84NUJq?= =?utf-8?B?S3Jab1lWbjQzMjFnTGtKSlYyNUJRN0V6ZFRjVFB0dzI4UFpucU9abm4rdHRj?= =?utf-8?B?Y3l6ZDlDRzZlc0tZejVWMUdxMFZlK0FHL3NBc3REZXRrOXZVZSsrZUoxWUtk?= =?utf-8?B?Z1EwTWhFTGdad0kyRUZUV1RJWlJSRGREaXBZUm9TQlBiSlVtc2QyTW5xLzN5?= =?utf-8?B?ZzM5MUJ6c285M1ZTQXpSZHc5SldLcmdzL3oxU25uQ3M5bjR1WW1VL1dLYXdH?= =?utf-8?B?YmtEb0dtNnRpc2tidFo3MVNVbUt0bFBSN0s3MEN5SWFWckxYZ3hwYjFZR0Jx?= =?utf-8?B?WmFybWRTQkpXb3JIbnRTWERxN1lzcGU3TUNRNGs1eWVuM0w2VEpqalptRWxk?= =?utf-8?B?c25xT2hVNlA4Zy9XWHUwbDZGYXl2RGJLcTdhRnd3ZUdja0M4Q0x1U01kczNs?= =?utf-8?B?OEdtOGRLSmpUZ2tOSEF6NlI5eXBkVFVIQktydGxzZXpZY2xhNGNBVTNRVU5s?= =?utf-8?B?Q21yQzNObkFobzMwczVOZys5SnJDVFlBTjdVQ2xTTjIrWk5yaklObXJpMFA4?= =?utf-8?B?NmJEek1lUDZBT1cwdVV6RytEM2lON0dnNGNjSG1GT3E3TlVQd1dtcmlNaHZs?= =?utf-8?B?Wjg3QW8xMWg5cVZDeHBicEQ4dTY0U3dCR1ovc0lDYzhGZkJRNDlZbkxZK3lm?= =?utf-8?B?TnY0ekpLK0NUQ0U1TXk5WkxtYlZ4Q1RCelFGZDZsUmtwOFdFUnN6Y3JhYXlo?= =?utf-8?B?eU1ZVWYwZ2pna1lDZi9IeWh6LzFVdEhmVTlQWHZoaHNxYWJQZ3FPc1Z0RmJp?= =?utf-8?B?T2c9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: z11fU0ynhzQFHb1caQlLecA9o9J5semT5Xrp6Xyi/oD5wCYxVPF75H6RxEj+YixaOVmG/zH6N4Mfps7PnOF0O7Mpo+AbVFm8Kg04McniywN8abXQPfsx3sRHe9wsjjO59W5Yn4DE7caoIRs6AdUa7tdpCKaL01pUw2yDDCty0ZUARLtHgUAPra+mgzqSNSawTAgyPyUolUr/w/NUYU6E7C3QTuzltQHmOmTc5owxkLpQCp84HQEsJP92WRWY793Mkwnb/9G4tycNCivfXZAWzlS7JKv3QirXxAhmOh2Jdr6i7+eMwxzH58N/rq+UqEUE+QrgOEZ5DKcLky3tQ4TQiF1jRRdBbUOqPeoYT6xQlLSjMDwnrzEOVK+p8CbNyjglhur8bxDW5nEgyeQ11aC8SmHmVsLC1hkEQihWuWpyvFXsgyX+f3ZW1RoDFyWwehNeAd2MJIaA10KDvijwmKQ4HHeo40XZOCpsF+rduEQEJGBWJaUkcRNruAuYPzKd8F1SUUE+Zj6T/sIferGISp7iJUIUV1+OjFHyTB9BJnVamdGd7PMeg4f5yWgCRolt9Oz2vY7m4qXR3l1LaYvQZ9maDoDc54ltZgcucBh0hsRssys= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 855ca1c5-d369-4e98-4545-08dd48835750 X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2025 20:58:30.0937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h/JGGncuaojBZ/t7El1Zb4yQklIuhgCQO74Aux0maaviYaQz1DvrbvQRzB0AKtf1p5qQQx6hI3vLJTkQUuFnvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7138 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-08_09,2025-02-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2501170000 definitions=main-2502080179 X-Proofpoint-GUID: LIeiHl56x74OzoqDaKr8qMRKQ8ZFq0L3 X-Proofpoint-ORIG-GUID: LIeiHl56x74OzoqDaKr8qMRKQ8ZFq0L3 On 2/8/25 2:31 PM, Daniel Gomez wrote: > On Sat, Feb 08, 2025 at 10:55:12AM +0100, Chuck Lever wrote: >> On 2/8/25 7:24 AM, Daniel Gomez wrote: >>> On Wed, Feb 05, 2025 at 11:18:54AM +0100, Daniel Gomez wrote: >>>> On Wed, Feb 05, 2025 at 09:50:51AM +0100, Joel Granados wrote: >>>>> Avoid "file not found" failures related to relative paths in >>>>> custom_source >>>>> >>>>> Signed-off-by: Joel Granados >>>> >>>> Looks good. Thanks for checking! >>>> >>>> Reviewed-by: Daniel Gomez >>> >>> Applied, thanks! >>> >>> >>>> >>>>> --- >>>>> After discussion in the list there is only one patch remaining. I have >>>>> dropped the ones that were "shot down" and kept the one that makes sure >>>>> we use full paths instead of relative; which seems to be a good idea. >>>>> >>>>> Changes in v2: >>>>> - Only one patch remains : "[PATCH RESEND 10/12] bringup: Use full path >>>>> when creating custom_source file", because some have already gone into >>>>> mainline and some other were "shot down" >>>>> - Link to v1: https://lore.kernel.org/r/20241218-jag-bringup_fixes-v1-0-0bf2e07c640c@kernel.org >>>>> --- >>>>> >>>>> --- >>>>> scripts/bringup_guestfs.sh | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/scripts/bringup_guestfs.sh b/scripts/bringup_guestfs.sh >>>>> index 74eecea..2c41999 100755 >>>>> --- a/scripts/bringup_guestfs.sh >>>>> +++ b/scripts/bringup_guestfs.sh >>>>> @@ -110,7 +110,7 @@ build_custom_image() >>>>> CUSTOM_IMAGE="${CUSTOM_IMAGE_DIR}/${OS_VERSION}.raw" >>>>> CUSTOM_IMAGE_OK="${CUSTOM_IMAGE_DIR}.ok" >>>>> CUSTOM_SOURCE="/etc/virt-builder/repos.d/kdevops-custom-images-${OS_VERSION}.conf" >>>>> - CUSTOM_INDEX="${CUSTOM_IMAGE_DIR}/index" >>>>> + CUSTOM_INDEX="$(realpath ${CUSTOM_IMAGE_DIR}/index)" >> >> My understanding is that 'realpath' is not available on every >> distribution...? Daniel, Luis, if this usage is OK, I'd like to use >> 'realpath' in one or two other spots. > > realpath is included coreutils, and it seems to be available on all supported > host distros. My quick check: > > + podman run --rm -it debian:latest bash -c 'dpkg -L coreutils | grep realpath' > /usr/bin/realpath > /usr/share/man/man1/realpath.1.gz > + podman run --rm -it fedora:latest bash -c 'rpm -ql coreutils | grep realpath' > /usr/bin/realpath > + podman run --rm -it opensuse/tumbleweed bash -c 'rpm -ql coreutils | grep realpath' > /usr/bin/realpath > + podman run --rm -it ubuntu:latest bash -c 'dpkg -L coreutils | grep realpath' > /usr/bin/realpath > /usr/share/man/man1/realpath.1.gz > > I'm curious, which distros are not shipping realpath? While looking at basename/dirname last week, I found articles such as this one: https://superuser.com/questions/771104/usr-bin-realpath-not-found-in-centos-6-5 But I see that the submission date on that article is a decade ago. If we believe realpath is available on every recent distro we care to run kdevops on, then there is no good reason to avoid using it. >>>>> mkdir -p ${CUSTOM_IMAGE_DIR} >>>>> >>>>> >>>>> --- >>>>> base-commit: 4bffd17ac6a3ac757a26897a75ffa185d623a8e4 >>>>> change-id: 20241217-jag-bringup_fixes-24ef1bc4211a >>>>> >>>>> Best regards, >>>>> -- >>>>> Joel Granados >>>>> >>>>> >>> >> >> >> -- >> Chuck Lever -- Chuck Lever