From: Heiner Kallweit <hkallweit1@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
Daniel Golle <daniel@makrotopia.org>,
Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Richard Cochran <richardcochran@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH net-next 3/8] net: phy: add getters for public members of struct phy_package_shared
Date: Thu, 27 Feb 2025 22:06:51 +0100 [thread overview]
Message-ID: <8069a3db-4fbc-4d89-a4d8-3d5b4cf4e89d@gmail.com> (raw)
In-Reply-To: <910cae0c-3d45-4cd3-b38a-49ab805a231e@redhat.com>
On 25.02.2025 10:12, Paolo Abeni wrote:
> On 2/25/25 3:01 AM, Jakub Kicinski wrote:
>> On Wed, 19 Feb 2025 22:04:47 +0100 Heiner Kallweit wrote:
>>> +struct device_node *phy_package_shared_get_node(struct phy_device *phydev);
>>> +void *phy_package_shared_get_priv(struct phy_device *phydev);
>>
>> A bit sad that none of the users can fit in a line with this naming.
>> Isn't "shared" implied by "package" here ?
>> How would you feel about phy_package_get_priv() ?
>
> FWIW I personally agree the latter would be a better name.
>
> @Heiner: could you please give that naming schema a shot here?
>
> /P
>
Sure. I'll submit a v2 with the suggested changes.
next prev parent reply other threads:[~2025-02-27 21:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 21:01 [PATCH net-next 0/8] net: phy: move PHY package code to its own source file Heiner Kallweit
2025-02-19 21:03 ` [PATCH net-next 1/8] net: phy: move PHY package code from phy_device.c to " Heiner Kallweit
2025-02-19 21:03 ` [PATCH net-next 2/8] net: phy: move PHY package related code from phy.h to phy_package.c Heiner Kallweit
2025-02-21 1:56 ` Andrew Lunn
2025-02-21 7:21 ` Heiner Kallweit
2025-02-25 9:05 ` Paolo Abeni
2025-02-19 21:04 ` [PATCH net-next 3/8] net: phy: add getters for public members of struct phy_package_shared Heiner Kallweit
2025-02-25 2:01 ` Jakub Kicinski
2025-02-25 9:12 ` Paolo Abeni
2025-02-27 21:06 ` Heiner Kallweit [this message]
2025-02-19 21:05 ` [PATCH net-next 4/8] net: phy: qca807x: use new phy_package_shared getters Heiner Kallweit
2025-02-19 21:06 ` [PATCH net-next 5/8] net: phy: micrel: " Heiner Kallweit
2025-02-19 21:06 ` [PATCH net-next 6/8] net: phy: mtk-ge-soc: " Heiner Kallweit
2025-02-19 21:07 ` [PATCH net-next 7/8] net: phy: mscc: " Heiner Kallweit
2025-02-19 21:08 ` [PATCH net-next 8/8] net: phy: make struct phy_package_shared private to phylib Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8069a3db-4fbc-4d89-a4d8-3d5b4cf4e89d@gmail.com \
--to=hkallweit1@gmail.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.