From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10807CD4F43 for ; Fri, 22 Sep 2023 09:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233017AbjIVJiF (ORCPT ); Fri, 22 Sep 2023 05:38:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231503AbjIVJiE (ORCPT ); Fri, 22 Sep 2023 05:38:04 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 71EA318F; Fri, 22 Sep 2023 02:37:58 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8769DA7; Fri, 22 Sep 2023 02:38:34 -0700 (PDT) Received: from [10.57.65.11] (unknown [10.57.65.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A97B3F5A1; Fri, 22 Sep 2023 02:37:53 -0700 (PDT) Message-ID: <806eceac-8f97-403d-bee7-4fbc9e75e872@arm.com> Date: Fri, 22 Sep 2023 10:37:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] powerpc: hugetlb: Convert set_huge_pte_at() to take vma Content-Language: en-GB To: Christophe Leroy , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921162007.1630149-3-ryan.roberts@arm.com> <0f2dd31a-a361-24ba-154d-4e614c0eff73@csgroup.eu> <597e7496-ef99-4505-88ee-91701af02835@arm.com> <5ee382da-0ed0-9fb1-7640-35ef77c195fc@csgroup.eu> <871d277e-6c4e-418a-9574-2e9117646ca2@arm.com> <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> From: Ryan Roberts In-Reply-To: <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On 22/09/2023 10:14, Christophe Leroy wrote: > > > Le 22/09/2023 à 10:41, Ryan Roberts a écrit : >> On 22/09/2023 09:10, Christophe Leroy wrote: >>> >>> >>>> I'm happy to take your proposed approach if that's your preference. Another >>>> option is to use a dummy VMA, as I have done in the core code, for the one call >>>> site that calls set_huge_pte_at() with init_mm: >>>> >>>> struct vm_area_struct vma = TLB_FLUSH_VMA(&init_mm, 0); >>>> >>>> This is an existing macro that creates a dummy vma with vma->vm_mm filled in. >>>> Then I pass &vma to the function. >>> >>> I don't like that, I prefer the solution I proposed. We already have a >>> couple places where powerpc do things based on whether vma is NULL or not. >>> >>>> >>>> Or yet another option would be to keep the mm param as is in set_huge_pte_at(), >>>> and add a size param to the function. But then all call sites have the burden of >>>> figuring out the size of the huge pte (although I think most know already). >>> >>> Indeed. >>> >>> arch_make_huge_pte() used to take a vma until commit 79c1c594f49a >>> ("mm/hugetlb: change parameters of arch_make_huge_pte()"). >>> >>> Should we try and have the same approach ? Or is it irrelevant ? >> >> See [1]; I'm going to rework to pass mm + size parameter since the current >> approach will break riscv. > > Can you pass a shift parameter instead of a size, like > arch_make_huge_pte() ? As far as I remember it is easier to handle a > shift than a size. Most of the call sites already have the size, not the shift. And arm64 needs the size, so it would have do (1UL << shift). So on that basis, I prefer to pass size. huge_pte_clear() already passes long unsigned sz, so I'd rather follow that pattern. > > Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E6D1CD4F42 for ; Fri, 22 Sep 2023 09:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SxzVDGQ+FzW6c4GSxztsPrG3f8EhVt1Q+jBY6TU07Zo=; b=HNgkYk+2/ClThq 23R1svFpXakY+F2I6xlG4u3jprpHoW4Oz37106dzlg/hYOrOpT70RrtEFS4zzUBQ5JE3ToPPc5Bj6 d0bme8d3wJe/17ialxZPkgeBr+TC+t+6KRF5A/AgnBSiOmUqH3fdHOBwzv7yxT3ulvY60bRMBVPKu jSf3utwBMVCKbt5YCizE5iBWNN0PYYz0HS3oCi40QMKVN8A6PSntjETv2RVncletRv6N01X0doKYH In2DIx1efEQ4pAjcoCmpMs3TJrDAf3BbVz0D9y6aSb4wi1evEJEGodApULK/yhXYtKCqXhID2/zhi 0fp4HalkHWWxC0bhXN2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjcbu-008bLO-2w; Fri, 22 Sep 2023 09:38:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjcbr-008bJS-0K; Fri, 22 Sep 2023 09:38:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8769DA7; Fri, 22 Sep 2023 02:38:34 -0700 (PDT) Received: from [10.57.65.11] (unknown [10.57.65.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A97B3F5A1; Fri, 22 Sep 2023 02:37:53 -0700 (PDT) Message-ID: <806eceac-8f97-403d-bee7-4fbc9e75e872@arm.com> Date: Fri, 22 Sep 2023 10:37:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] powerpc: hugetlb: Convert set_huge_pte_at() to take vma Content-Language: en-GB To: Christophe Leroy , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921162007.1630149-3-ryan.roberts@arm.com> <0f2dd31a-a361-24ba-154d-4e614c0eff73@csgroup.eu> <597e7496-ef99-4505-88ee-91701af02835@arm.com> <5ee382da-0ed0-9fb1-7640-35ef77c195fc@csgroup.eu> <871d277e-6c4e-418a-9574-2e9117646ca2@arm.com> <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> From: Ryan Roberts In-Reply-To: <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_023803_231658_D5361ECB X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gMjIvMDkvMjAyMyAxMDoxNCwgQ2hyaXN0b3BoZSBMZXJveSB3cm90ZToKPiAKPiAKPiBMZSAy Mi8wOS8yMDIzIMOgIDEwOjQxLCBSeWFuIFJvYmVydHMgYSDDqWNyaXTCoDoKPj4gT24gMjIvMDkv MjAyMyAwOToxMCwgQ2hyaXN0b3BoZSBMZXJveSB3cm90ZToKPj4+Cj4+Pgo+Pj4+IEknbSBoYXBw eSB0byB0YWtlIHlvdXIgcHJvcG9zZWQgYXBwcm9hY2ggaWYgdGhhdCdzIHlvdXIgcHJlZmVyZW5j ZS4gQW5vdGhlcgo+Pj4+IG9wdGlvbiBpcyB0byB1c2UgYSBkdW1teSBWTUEsIGFzIEkgaGF2ZSBk b25lIGluIHRoZSBjb3JlIGNvZGUsIGZvciB0aGUgb25lIGNhbGwKPj4+PiBzaXRlIHRoYXQgY2Fs bHMgc2V0X2h1Z2VfcHRlX2F0KCkgd2l0aCBpbml0X21tOgo+Pj4+Cj4+Pj4gc3RydWN0IHZtX2Fy ZWFfc3RydWN0IHZtYSA9IFRMQl9GTFVTSF9WTUEoJmluaXRfbW0sIDApOwo+Pj4+Cj4+Pj4gVGhp cyBpcyBhbiBleGlzdGluZyBtYWNybyB0aGF0IGNyZWF0ZXMgYSBkdW1teSB2bWEgd2l0aCB2bWEt PnZtX21tIGZpbGxlZCBpbi4KPj4+PiBUaGVuIEkgcGFzcyAmdm1hIHRvIHRoZSBmdW5jdGlvbi4K Pj4+Cj4+PiBJIGRvbid0IGxpa2UgdGhhdCwgSSBwcmVmZXIgdGhlIHNvbHV0aW9uIEkgcHJvcG9z ZWQuIFdlIGFscmVhZHkgaGF2ZSBhCj4+PiBjb3VwbGUgcGxhY2VzIHdoZXJlIHBvd2VycGMgZG8g dGhpbmdzIGJhc2VkIG9uIHdoZXRoZXIgdm1hIGlzIE5VTEwgb3Igbm90Lgo+Pj4KPj4+Pgo+Pj4+ IE9yIHlldCBhbm90aGVyIG9wdGlvbiB3b3VsZCBiZSB0byBrZWVwIHRoZSBtbSBwYXJhbSBhcyBp cyBpbiBzZXRfaHVnZV9wdGVfYXQoKSwKPj4+PiBhbmQgYWRkIGEgc2l6ZSBwYXJhbSB0byB0aGUg ZnVuY3Rpb24uIEJ1dCB0aGVuIGFsbCBjYWxsIHNpdGVzIGhhdmUgdGhlIGJ1cmRlbiBvZgo+Pj4+ IGZpZ3VyaW5nIG91dCB0aGUgc2l6ZSBvZiB0aGUgaHVnZSBwdGUgKGFsdGhvdWdoIEkgdGhpbmsg bW9zdCBrbm93IGFscmVhZHkpLgo+Pj4KPj4+IEluZGVlZC4KPj4+Cj4+PiBhcmNoX21ha2VfaHVn ZV9wdGUoKSB1c2VkIHRvIHRha2UgYSB2bWEgdW50aWwgY29tbWl0IDc5YzFjNTk0ZjQ5YQo+Pj4g KCJtbS9odWdldGxiOiBjaGFuZ2UgcGFyYW1ldGVycyBvZiBhcmNoX21ha2VfaHVnZV9wdGUoKSIp Lgo+Pj4KPj4+IFNob3VsZCB3ZSB0cnkgYW5kIGhhdmUgdGhlIHNhbWUgYXBwcm9hY2ggPyBPciBp cyBpdCBpcnJlbGV2YW50ID8KPj4KPj4gU2VlIFsxXTsgSSdtIGdvaW5nIHRvIHJld29yayB0byBw YXNzIG1tICsgc2l6ZSBwYXJhbWV0ZXIgc2luY2UgdGhlIGN1cnJlbnQKPj4gYXBwcm9hY2ggd2ls bCBicmVhayByaXNjdi4KPiAKPiBDYW4geW91IHBhc3MgYSBzaGlmdCBwYXJhbWV0ZXIgaW5zdGVh ZCBvZiBhIHNpemUsIGxpa2UgCj4gYXJjaF9tYWtlX2h1Z2VfcHRlKCkgPyBBcyBmYXIgYXMgSSBy ZW1lbWJlciBpdCBpcyBlYXNpZXIgdG8gaGFuZGxlIGEgCj4gc2hpZnQgdGhhbiBhIHNpemUuCgpN b3N0IG9mIHRoZSBjYWxsIHNpdGVzIGFscmVhZHkgaGF2ZSB0aGUgc2l6ZSwgbm90IHRoZSBzaGlm dC4gQW5kIGFybTY0IG5lZWRzIHRoZQpzaXplLCBzbyBpdCB3b3VsZCBoYXZlIGRvICgxVUwgPDwg c2hpZnQpLiBTbyBvbiB0aGF0IGJhc2lzLCBJIHByZWZlciB0byBwYXNzCnNpemUuIGh1Z2VfcHRl X2NsZWFyKCkgYWxyZWFkeSBwYXNzZXMgbG9uZyB1bnNpZ25lZCBzeiwgc28gSSdkIHJhdGhlciBm b2xsb3cKdGhhdCBwYXR0ZXJuLgoKPiAKPiBDaHJpc3RvcGhlCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0Cmxp bnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E757CD4F42 for ; Fri, 22 Sep 2023 09:39:08 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RsRzv03SZz3dgG for ; Fri, 22 Sep 2023 19:39:07 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=ryan.roberts@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4RsRzF4lVLz2xFm for ; Fri, 22 Sep 2023 19:38:31 +1000 (AEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8769DA7; Fri, 22 Sep 2023 02:38:34 -0700 (PDT) Received: from [10.57.65.11] (unknown [10.57.65.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A97B3F5A1; Fri, 22 Sep 2023 02:37:53 -0700 (PDT) Message-ID: <806eceac-8f97-403d-bee7-4fbc9e75e872@arm.com> Date: Fri, 22 Sep 2023 10:37:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] powerpc: hugetlb: Convert set_huge_pte_at() to take vma Content-Language: en-GB To: Christophe Leroy , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921162007.1630149-3-ryan.roberts@arm.com> <0f2dd31a-a361-24ba-154d-4e614c0eff73@csgroup.eu> <597e7496-ef99-4505-88ee-91701af02835@arm.com> <5ee382da-0ed0-9fb1-7640-35ef77c195fc@csgroup.eu> <871d277e-6c4e-418a-9574-2e9117646ca2@arm.com> <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> From: Ryan Roberts In-Reply-To: <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-s390@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "linux-mm@kvack.org" , "sparclinux@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 22/09/2023 10:14, Christophe Leroy wrote: > > > Le 22/09/2023 à 10:41, Ryan Roberts a écrit : >> On 22/09/2023 09:10, Christophe Leroy wrote: >>> >>> >>>> I'm happy to take your proposed approach if that's your preference. Another >>>> option is to use a dummy VMA, as I have done in the core code, for the one call >>>> site that calls set_huge_pte_at() with init_mm: >>>> >>>> struct vm_area_struct vma = TLB_FLUSH_VMA(&init_mm, 0); >>>> >>>> This is an existing macro that creates a dummy vma with vma->vm_mm filled in. >>>> Then I pass &vma to the function. >>> >>> I don't like that, I prefer the solution I proposed. We already have a >>> couple places where powerpc do things based on whether vma is NULL or not. >>> >>>> >>>> Or yet another option would be to keep the mm param as is in set_huge_pte_at(), >>>> and add a size param to the function. But then all call sites have the burden of >>>> figuring out the size of the huge pte (although I think most know already). >>> >>> Indeed. >>> >>> arch_make_huge_pte() used to take a vma until commit 79c1c594f49a >>> ("mm/hugetlb: change parameters of arch_make_huge_pte()"). >>> >>> Should we try and have the same approach ? Or is it irrelevant ? >> >> See [1]; I'm going to rework to pass mm + size parameter since the current >> approach will break riscv. > > Can you pass a shift parameter instead of a size, like > arch_make_huge_pte() ? As far as I remember it is easier to handle a > shift than a size. Most of the call sites already have the size, not the shift. And arm64 needs the size, so it would have do (1UL << shift). So on that basis, I prefer to pass size. huge_pte_clear() already passes long unsigned sz, so I'd rather follow that pattern. > > Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 891DBCD4F42 for ; Fri, 22 Sep 2023 09:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BboUmxVwxtw5n2hlBPm56A6Ft8taFH88HYGldLSWeYM=; b=TsxPN9KGLTFZxw IGv00y6nkY6K3hJwCne/nTC+jJb5yACxDN2ArxQAh7nK31XwGVDEh5iJep6ZQCoa39s1XQUrvRoM5 WyV+HJXpXA5/9z8EOLcgtxyRhlA5IyeauKYlZeeA/HNEwiUzu9i+A16mc3Ond+DsFMP5jUQPtpQEd 8H5xLrC0Sb3u0QRqEVSic5yCuIuWkOP5SeZnQp4MJWefNFI3jAMr93Oll/L9Tb/4iRbddg/i0MQHi XFPopf+GBN7s+H89MY/kpWxCMNMHSMVMbI01pkazN/7pJxY8tdJFVxEhOj6fxICYG3tbIr0uk5xdr buUWX4Tjcdtt7UmaKP6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjcbu-008bLI-1P; Fri, 22 Sep 2023 09:38:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjcbr-008bJS-0K; Fri, 22 Sep 2023 09:38:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8769DA7; Fri, 22 Sep 2023 02:38:34 -0700 (PDT) Received: from [10.57.65.11] (unknown [10.57.65.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4A97B3F5A1; Fri, 22 Sep 2023 02:37:53 -0700 (PDT) Message-ID: <806eceac-8f97-403d-bee7-4fbc9e75e872@arm.com> Date: Fri, 22 Sep 2023 10:37:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] powerpc: hugetlb: Convert set_huge_pte_at() to take vma Content-Language: en-GB To: Christophe Leroy , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921162007.1630149-3-ryan.roberts@arm.com> <0f2dd31a-a361-24ba-154d-4e614c0eff73@csgroup.eu> <597e7496-ef99-4505-88ee-91701af02835@arm.com> <5ee382da-0ed0-9fb1-7640-35ef77c195fc@csgroup.eu> <871d277e-6c4e-418a-9574-2e9117646ca2@arm.com> <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> From: Ryan Roberts In-Reply-To: <1cc4d995-efeb-9d15-446f-475e63154a2d@csgroup.eu> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230922_023803_231658_D5361ECB X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjIvMDkvMjAyMyAxMDoxNCwgQ2hyaXN0b3BoZSBMZXJveSB3cm90ZToKPiAKPiAKPiBMZSAy Mi8wOS8yMDIzIMOgIDEwOjQxLCBSeWFuIFJvYmVydHMgYSDDqWNyaXTCoDoKPj4gT24gMjIvMDkv MjAyMyAwOToxMCwgQ2hyaXN0b3BoZSBMZXJveSB3cm90ZToKPj4+Cj4+Pgo+Pj4+IEknbSBoYXBw eSB0byB0YWtlIHlvdXIgcHJvcG9zZWQgYXBwcm9hY2ggaWYgdGhhdCdzIHlvdXIgcHJlZmVyZW5j ZS4gQW5vdGhlcgo+Pj4+IG9wdGlvbiBpcyB0byB1c2UgYSBkdW1teSBWTUEsIGFzIEkgaGF2ZSBk b25lIGluIHRoZSBjb3JlIGNvZGUsIGZvciB0aGUgb25lIGNhbGwKPj4+PiBzaXRlIHRoYXQgY2Fs bHMgc2V0X2h1Z2VfcHRlX2F0KCkgd2l0aCBpbml0X21tOgo+Pj4+Cj4+Pj4gc3RydWN0IHZtX2Fy ZWFfc3RydWN0IHZtYSA9IFRMQl9GTFVTSF9WTUEoJmluaXRfbW0sIDApOwo+Pj4+Cj4+Pj4gVGhp cyBpcyBhbiBleGlzdGluZyBtYWNybyB0aGF0IGNyZWF0ZXMgYSBkdW1teSB2bWEgd2l0aCB2bWEt PnZtX21tIGZpbGxlZCBpbi4KPj4+PiBUaGVuIEkgcGFzcyAmdm1hIHRvIHRoZSBmdW5jdGlvbi4K Pj4+Cj4+PiBJIGRvbid0IGxpa2UgdGhhdCwgSSBwcmVmZXIgdGhlIHNvbHV0aW9uIEkgcHJvcG9z ZWQuIFdlIGFscmVhZHkgaGF2ZSBhCj4+PiBjb3VwbGUgcGxhY2VzIHdoZXJlIHBvd2VycGMgZG8g dGhpbmdzIGJhc2VkIG9uIHdoZXRoZXIgdm1hIGlzIE5VTEwgb3Igbm90Lgo+Pj4KPj4+Pgo+Pj4+ IE9yIHlldCBhbm90aGVyIG9wdGlvbiB3b3VsZCBiZSB0byBrZWVwIHRoZSBtbSBwYXJhbSBhcyBp cyBpbiBzZXRfaHVnZV9wdGVfYXQoKSwKPj4+PiBhbmQgYWRkIGEgc2l6ZSBwYXJhbSB0byB0aGUg ZnVuY3Rpb24uIEJ1dCB0aGVuIGFsbCBjYWxsIHNpdGVzIGhhdmUgdGhlIGJ1cmRlbiBvZgo+Pj4+ IGZpZ3VyaW5nIG91dCB0aGUgc2l6ZSBvZiB0aGUgaHVnZSBwdGUgKGFsdGhvdWdoIEkgdGhpbmsg bW9zdCBrbm93IGFscmVhZHkpLgo+Pj4KPj4+IEluZGVlZC4KPj4+Cj4+PiBhcmNoX21ha2VfaHVn ZV9wdGUoKSB1c2VkIHRvIHRha2UgYSB2bWEgdW50aWwgY29tbWl0IDc5YzFjNTk0ZjQ5YQo+Pj4g KCJtbS9odWdldGxiOiBjaGFuZ2UgcGFyYW1ldGVycyBvZiBhcmNoX21ha2VfaHVnZV9wdGUoKSIp Lgo+Pj4KPj4+IFNob3VsZCB3ZSB0cnkgYW5kIGhhdmUgdGhlIHNhbWUgYXBwcm9hY2ggPyBPciBp cyBpdCBpcnJlbGV2YW50ID8KPj4KPj4gU2VlIFsxXTsgSSdtIGdvaW5nIHRvIHJld29yayB0byBw YXNzIG1tICsgc2l6ZSBwYXJhbWV0ZXIgc2luY2UgdGhlIGN1cnJlbnQKPj4gYXBwcm9hY2ggd2ls bCBicmVhayByaXNjdi4KPiAKPiBDYW4geW91IHBhc3MgYSBzaGlmdCBwYXJhbWV0ZXIgaW5zdGVh ZCBvZiBhIHNpemUsIGxpa2UgCj4gYXJjaF9tYWtlX2h1Z2VfcHRlKCkgPyBBcyBmYXIgYXMgSSBy ZW1lbWJlciBpdCBpcyBlYXNpZXIgdG8gaGFuZGxlIGEgCj4gc2hpZnQgdGhhbiBhIHNpemUuCgpN b3N0IG9mIHRoZSBjYWxsIHNpdGVzIGFscmVhZHkgaGF2ZSB0aGUgc2l6ZSwgbm90IHRoZSBzaGlm dC4gQW5kIGFybTY0IG5lZWRzIHRoZQpzaXplLCBzbyBpdCB3b3VsZCBoYXZlIGRvICgxVUwgPDwg c2hpZnQpLiBTbyBvbiB0aGF0IGJhc2lzLCBJIHByZWZlciB0byBwYXNzCnNpemUuIGh1Z2VfcHRl X2NsZWFyKCkgYWxyZWFkeSBwYXNzZXMgbG9uZyB1bnNpZ25lZCBzeiwgc28gSSdkIHJhdGhlciBm b2xsb3cKdGhhdCBwYXR0ZXJuLgoKPiAKPiBDaHJpc3RvcGhlCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=