From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [Y2038] [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions Date: Tue, 21 Apr 2015 10:45:48 +0200 Message-ID: <8072977.i0FsrGW3CD@wuerfel> References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: y2038@lists.linaro.org Cc: Xunlei Pang , peterz@infradead.org, heiko.carstens@de.ibm.com, paulus@samba.org, cl@linux.com, Heena Sirwani , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, rafael.j.wysocki@intel.com, Andrew Hunter , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Paul Turner , riel@redhat.com, Richard Cochran , tj@kernel.org, John Stultz , Thomas Gleixner , rth@twiddle.net, Baolin Wang , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, schwidefsky@de.ibm.com, linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org T24gVHVlc2RheSAyMSBBcHJpbCAyMDE1IDE2OjM2OjEzIEJhb2xpbiBXYW5nIHdyb3RlOgo+IE9u IDIxIEFwcmlsIDIwMTUgYXQgMDQ6NDgsIFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4 LmRlPiB3cm90ZToKPiAKPiA+IE9uIE1vbiwgMjAgQXByIDIwMTUsIEJhb2xpbiBXYW5nIHdyb3Rl Ogo+ID4gPiAgLyogU2V0IGNsb2NrX3JlYWx0aW1lICovCj4gPiA+ICBzdGF0aWMgaW50IHBvc2l4 X2Nsb2NrX3JlYWx0aW1lX3NldChjb25zdCBjbG9ja2lkX3Qgd2hpY2hfY2xvY2ssCj4gPiA+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgdGltZXNwZWMgKnRw KQo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHRp bWVzcGVjNjQgKnRwKQo+ID4gPiAgewo+ID4gPiAtICAgICByZXR1cm4gZG9fc3lzX3NldHRpbWVv ZmRheSh0cCwgTlVMTCk7Cj4gPiA+ICsgICAgIHN0cnVjdCB0aW1lc3BlYyB0cyA9IHRpbWVzcGVj NjRfdG9fdGltZXNwZWMoKnRwKTsKPiA+ID4gKwo+ID4gPiArICAgICByZXR1cm4gZG9fc3lzX3Nl dHRpbWVvZmRheSgmdHMsIE5VTEwpOwo+ID4KPiA+IFNpZ2guIE5vLiBXZSBmaXJzdCBwcm92aWRl IGEgcHJvcGVyIGZ1bmN0aW9uIGZvciB0aGlzLCB3aGljaCB0YWtlcyBhCj4gPiB0aW1lc3BlYzY0 LCBpLmUuIGRvX3N5c19zZXR0aW1lb2ZkYXk2NCgpIGluc3RlYWQgb2YgaGF2aW5nIHRoaXMKPiA+ IHdyYXBwZXIgbWVzcyBhbGwgb3ZlciB0aGUgcGxhY2UuCj4gPgo+IAo+IFRoYW5rcyBmb3IgeW91 ciBjb21tZW50cyxidXQgaWYgdXNlIGRvX3N5c19zZXR0aW1lb2ZkYXk2NCgpIGhlcmUgdGhhdAo+ IHdpbGwgIGludHJvZHVjZQo+IGEgc2VjdXJpdHkgYnVnOiBkb19zeXNfc2V0dGltZW9mZGF5IGNv bnRhaW5zIGEgY2FwYWJpbGl0eQo+IGNoZWNrIHRoYXQgbm9ybWFsbHkgcHJldmVudHMgbm9uLXJv b3QgdXNlcnMgZnJvbSBzZXR0aW5nIHRoZSB0aW1lLgo+IAo+IFdpdGggeW91ciBjaGFuZ2UsIGFu eSB1c2VyIGNhbiBzZXQgdGhlIHN5c3RlbSB0aW1lLgoKSGUgd2FzIGFza2luZyBmb3IgYSBuZXcg ZG9fc3lzX3NldHRpbWVvZmRheTY0IGZ1bmN0aW9uIHRvIGJlIGFkZGVkLApub3QgdXNpbmcgdGhl IGxvdy1sZXZlbCBkb19zZXR0aW1lb2ZkYXk2NC4KCglBcm5kCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGlu dXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3Rp bmZvL2xpbnV4cHBjLWRldg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.13]:50712 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbbDUIrl (ORCPT ); Tue, 21 Apr 2015 04:47:41 -0400 From: Arnd Bergmann Subject: Re: [Y2038] [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions Date: Tue, 21 Apr 2015 10:45:48 +0200 Message-ID: <8072977.i0FsrGW3CD@wuerfel> In-Reply-To: References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-arch-owner@vger.kernel.org List-ID: To: y2038@lists.linaro.org Cc: Baolin Wang , Thomas Gleixner , Xunlei Pang , peterz@infradead.org, benh@kernel.crashing.org, heiko.carstens@de.ibm.com, paulus@samba.org, cl@linux.com, Heena Sirwani , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, mpe@ellerman.id.au, rafael.j.wysocki@intel.com, Andrew Hunter , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Paul Turner , riel@redhat.com, Richard Cochran , schwidefsky@de.ibm.com, John Stultz , rth@twiddle.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tj@kernel.org, linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org Message-ID: <20150421084548.JfnZBiv8Hy5AIEqzUv2fwX_3MsqmILgQK8jLKvuTr3g@z> On Tuesday 21 April 2015 16:36:13 Baolin Wang wrote: > On 21 April 2015 at 04:48, Thomas Gleixner wrote: > > > On Mon, 20 Apr 2015, Baolin Wang wrote: > > > /* Set clock_realtime */ > > > static int posix_clock_realtime_set(const clockid_t which_clock, > > > - const struct timespec *tp) > > > + const struct timespec64 *tp) > > > { > > > - return do_sys_settimeofday(tp, NULL); > > > + struct timespec ts = timespec64_to_timespec(*tp); > > > + > > > + return do_sys_settimeofday(&ts, NULL); > > > > Sigh. No. We first provide a proper function for this, which takes a > > timespec64, i.e. do_sys_settimeofday64() instead of having this > > wrapper mess all over the place. > > > > Thanks for your comments,but if use do_sys_settimeofday64() here that > will introduce > a security bug: do_sys_settimeofday contains a capability > check that normally prevents non-root users from setting the time. > > With your change, any user can set the system time. He was asking for a new do_sys_settimeofday64 function to be added, not using the low-level do_settimeofday64. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id CAB471A0025 for ; Tue, 21 Apr 2015 18:46:28 +1000 (AEST) From: Arnd Bergmann To: y2038@lists.linaro.org Subject: Re: [Y2038] [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions Date: Tue, 21 Apr 2015 10:45:48 +0200 Message-ID: <8072977.i0FsrGW3CD@wuerfel> In-Reply-To: References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Xunlei Pang , peterz@infradead.org, heiko.carstens@de.ibm.com, paulus@samba.org, cl@linux.com, Heena Sirwani , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, rafael.j.wysocki@intel.com, Andrew Hunter , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Paul Turner , riel@redhat.com, Richard Cochran , tj@kernel.org, John Stultz , Thomas Gleixner , rth@twiddle.net, Baolin Wang , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, schwidefsky@de.ibm.com, linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday 21 April 2015 16:36:13 Baolin Wang wrote: > On 21 April 2015 at 04:48, Thomas Gleixner wrote: > > > On Mon, 20 Apr 2015, Baolin Wang wrote: > > > /* Set clock_realtime */ > > > static int posix_clock_realtime_set(const clockid_t which_clock, > > > - const struct timespec *tp) > > > + const struct timespec64 *tp) > > > { > > > - return do_sys_settimeofday(tp, NULL); > > > + struct timespec ts = timespec64_to_timespec(*tp); > > > + > > > + return do_sys_settimeofday(&ts, NULL); > > > > Sigh. No. We first provide a proper function for this, which takes a > > timespec64, i.e. do_sys_settimeofday64() instead of having this > > wrapper mess all over the place. > > > > Thanks for your comments,but if use do_sys_settimeofday64() here that > will introduce > a security bug: do_sys_settimeofday contains a capability > check that normally prevents non-root users from setting the time. > > With your change, any user can set the system time. He was asking for a new do_sys_settimeofday64 function to be added, not using the low-level do_settimeofday64. Arnd