From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:40464 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726030AbeHTOQK (ORCPT ); Mon, 20 Aug 2018 10:16:10 -0400 From: Laurent Pinchart To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com Subject: Re: [PROTO][PATCH 10/10] arm64: dts: renesas: r8a77995-draak: add HDMI output Date: Mon, 20 Aug 2018 14:01:54 +0300 Message-ID: <80779849.cAp1Gtn18s@avalon> In-Reply-To: <1534254604-24204-11-git-send-email-uli+renesas@fpond.eu> References: <1534254604-24204-1-git-send-email-uli+renesas@fpond.eu> <1534254604-24204-11-git-send-email-uli+renesas@fpond.eu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Ulrich, Thank you for the patch. On Tuesday, 14 August 2018 16:50:04 EEST Ulrich Hecht wrote: > Adds LVDS decoder, HDMI encoder and connector for Draak boards. > > Signed-off-by: Ulrich Hecht > Reviewed-by: Laurent Pinchart I'm afraid I'll have to revoke that, as it applied to the patch before the addition of the max-clock and min-vrefresh properties. Let's discuss them in replies to patch 05/10 in this series. > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 84 +++++++++++++++++++++++ > 1 file changed, 84 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index bd5c6fa..157adf9 > 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -24,6 +24,41 @@ > stdout-path = "serial0:115200n8"; > }; > > + lvds-decoder { > + compatible = "thine,thc63lvd1024"; > + vcc-supply = <®_3p3v>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + thc63lvd1024_in: endpoint { > + remote-endpoint = <&lvds0_out>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + thc63lvd1024_out: endpoint { > + remote-endpoint = <&adv7511_in>; > + }; > + }; > + }; > + }; > + > + hdmi-out { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_out: endpoint { > + remote-endpoint = <&adv7511_out>; > + }; > + }; > + }; > + > vga { > compatible = "vga-connector"; > > @@ -218,6 +253,43 @@ > > }; > > + hdmi@39 { > + compatible = "adi,adv7511w"; > + reg = <0x39>, <0x3f>, <0x38>, <0x3c>; > + reg-names = "main", "edid", "packet", "cec"; > + interrupt-parent = <&gpio1>; > + interrupts = <28 IRQ_TYPE_LEVEL_LOW>; > + > + /* Depends on LVDS */ > + max-clock = <135000000>; > + min-vrefresh = <50>; > + > + adi,input-depth = <8>; > + adi,input-colorspace = "rgb"; > + adi,input-clock = "1x"; > + adi,input-style = <1>; > + adi,input-justification = "evenly"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + adv7511_in: endpoint { > + remote-endpoint = <&thc63lvd1024_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + adv7511_out: endpoint { > + remote-endpoint = <&hdmi_con_out>; > + }; > + }; > + }; > + }; > + > hdmi-decoder@4c { > compatible = "adi,adv7612"; > reg = <0x4c>; > @@ -283,6 +355,18 @@ > }; > }; > > +&lvds0 { > + status = "okay"; > + > + ports { > + port@1 { > + lvds0_out: endpoint { > + remote-endpoint = <&thc63lvd1024_in>; > + }; > + }; > + }; > +}; > + > &ehci0 { > status = "okay"; > }; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PROTO][PATCH 10/10] arm64: dts: renesas: r8a77995-draak: add HDMI output Date: Mon, 20 Aug 2018 14:01:54 +0300 Message-ID: <80779849.cAp1Gtn18s@avalon> References: <1534254604-24204-1-git-send-email-uli+renesas@fpond.eu> <1534254604-24204-11-git-send-email-uli+renesas@fpond.eu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D9756E0EF for ; Mon, 20 Aug 2018 11:01:00 +0000 (UTC) In-Reply-To: <1534254604-24204-11-git-send-email-uli+renesas@fpond.eu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ulrich Hecht Cc: linux-renesas-soc@vger.kernel.org, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVWxyaWNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxNCBBdWd1 c3QgMjAxOCAxNjo1MDowNCBFRVNUIFVscmljaCBIZWNodCB3cm90ZToKPiBBZGRzIExWRFMgZGVj b2RlciwgSERNSSBlbmNvZGVyIGFuZCBjb25uZWN0b3IgZm9yIERyYWFrIGJvYXJkcy4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBVbHJpY2ggSGVjaHQgPHVsaStyZW5lc2FzQGZwb25kLmV1Pgo+IFJldmll d2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5j b20+CgpJJ20gYWZyYWlkIEknbGwgaGF2ZSB0byByZXZva2UgdGhhdCwgYXMgaXQgYXBwbGllZCB0 byB0aGUgcGF0Y2ggYmVmb3JlIHRoZSAKYWRkaXRpb24gb2YgdGhlIG1heC1jbG9jayBhbmQgbWlu LXZyZWZyZXNoIHByb3BlcnRpZXMuIExldCdzIGRpc2N1c3MgdGhlbSBpbiAKcmVwbGllcyB0byBw YXRjaCAwNS8xMCBpbiB0aGlzIHNlcmllcy4KCj4gLS0tCj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMv cmVuZXNhcy9yOGE3Nzk5NS1kcmFhay5kdHMgfCA4NCArKysrKysrKysrKysrKysrKysrKysrKwo+ ICAxIGZpbGUgY2hhbmdlZCwgODQgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9hcmNo L2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTUtZHJhYWsuZHRzCj4gYi9hcmNoL2FybTY0 L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTUtZHJhYWsuZHRzIGluZGV4IGJkNWM2ZmEuLjE1N2Fk ZjkKPiAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3JlbmVzYXMvcjhhNzc5OTUt ZHJhYWsuZHRzCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTk1LWRy YWFrLmR0cwo+IEBAIC0yNCw2ICsyNCw0MSBAQAo+ICAJCXN0ZG91dC1wYXRoID0gInNlcmlhbDA6 MTE1MjAwbjgiOwo+ICAJfTsKPiAKPiArCWx2ZHMtZGVjb2RlciB7Cj4gKwkJY29tcGF0aWJsZSA9 ICJ0aGluZSx0aGM2M2x2ZDEwMjQiOwo+ICsJCXZjYy1zdXBwbHkgPSA8JnJlZ18zcDN2PjsKPiAr Cj4gKwkJcG9ydHMgewo+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkJI3NpemUtY2Vs bHMgPSA8MD47Cj4gKwo+ICsJCQlwb3J0QDAgewo+ICsJCQkJcmVnID0gPDA+Owo+ICsJCQkJdGhj NjNsdmQxMDI0X2luOiBlbmRwb2ludCB7Cj4gKwkJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZsdmRz MF9vdXQ+Owo+ICsJCQkJfTsKPiArCQkJfTsKPiArCj4gKwkJCXBvcnRAMiB7Cj4gKwkJCQlyZWcg PSA8Mj47Cj4gKwkJCQl0aGM2M2x2ZDEwMjRfb3V0OiBlbmRwb2ludCB7Cj4gKwkJCQkJcmVtb3Rl LWVuZHBvaW50ID0gPCZhZHY3NTExX2luPjsKPiArCQkJCX07Cj4gKwkJCX07Cj4gKwkJfTsKPiAr CX07Cj4gKwo+ICsJaGRtaS1vdXQgewo+ICsJCWNvbXBhdGlibGUgPSAiaGRtaS1jb25uZWN0b3Ii Owo+ICsJCXR5cGUgPSAiYSI7Cj4gKwo+ICsJCXBvcnQgewo+ICsJCQloZG1pX2Nvbl9vdXQ6IGVu ZHBvaW50IHsKPiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmYWR2NzUxMV9vdXQ+Owo+ICsJCQl9 Owo+ICsJCX07Cj4gKwl9Owo+ICsKPiAgCXZnYSB7Cj4gIAkJY29tcGF0aWJsZSA9ICJ2Z2EtY29u bmVjdG9yIjsKPiAKPiBAQCAtMjE4LDYgKzI1Myw0MyBAQAo+IAo+ICAJfTsKPiAKPiArCWhkbWlA Mzkgewo+ICsJCWNvbXBhdGlibGUgPSAiYWRpLGFkdjc1MTF3IjsKPiArCQlyZWcgPSA8MHgzOT4s IDwweDNmPiwgPDB4Mzg+LCA8MHgzYz47Cj4gKwkJcmVnLW5hbWVzID0gIm1haW4iLCAiZWRpZCIs ICJwYWNrZXQiLCAiY2VjIjsKPiArCQlpbnRlcnJ1cHQtcGFyZW50ID0gPCZncGlvMT47Cj4gKwkJ aW50ZXJydXB0cyA9IDwyOCBJUlFfVFlQRV9MRVZFTF9MT1c+Owo+ICsKPiArCQkvKiBEZXBlbmRz IG9uIExWRFMgKi8KPiArCQltYXgtY2xvY2sgPSA8MTM1MDAwMDAwPjsKPiArCQltaW4tdnJlZnJl c2ggPSA8NTA+Owo+ICsKPiArCQlhZGksaW5wdXQtZGVwdGggPSA8OD47Cj4gKwkJYWRpLGlucHV0 LWNvbG9yc3BhY2UgPSAicmdiIjsKPiArCQlhZGksaW5wdXQtY2xvY2sgPSAiMXgiOwo+ICsJCWFk aSxpbnB1dC1zdHlsZSA9IDwxPjsKPiArCQlhZGksaW5wdXQtanVzdGlmaWNhdGlvbiA9ICJldmVu bHkiOwo+ICsKPiArCQlwb3J0cyB7Cj4gKwkJCSNhZGRyZXNzLWNlbGxzID0gPDE+Owo+ICsJCQkj c2l6ZS1jZWxscyA9IDwwPjsKPiArCj4gKwkJCXBvcnRAMCB7Cj4gKwkJCQlyZWcgPSA8MD47Cj4g KwkJCQlhZHY3NTExX2luOiBlbmRwb2ludCB7Cj4gKwkJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZ0 aGM2M2x2ZDEwMjRfb3V0PjsKPiArCQkJCX07Cj4gKwkJCX07Cj4gKwo+ICsJCQlwb3J0QDEgewo+ ICsJCQkJcmVnID0gPDE+Owo+ICsJCQkJYWR2NzUxMV9vdXQ6IGVuZHBvaW50IHsKPiArCQkJCQly ZW1vdGUtZW5kcG9pbnQgPSA8JmhkbWlfY29uX291dD47Cj4gKwkJCQl9Owo+ICsJCQl9Owo+ICsJ CX07Cj4gKwl9Owo+ICsKPiAgCWhkbWktZGVjb2RlckA0YyB7Cj4gIAkJY29tcGF0aWJsZSA9ICJh ZGksYWR2NzYxMiI7Cj4gIAkJcmVnID0gPDB4NGM+Owo+IEBAIC0yODMsNiArMzU1LDE4IEBACj4g IAl9Owo+ICB9Owo+IAo+ICsmbHZkczAgewo+ICsJc3RhdHVzID0gIm9rYXkiOwo+ICsKPiArCXBv cnRzIHsKPiArCQlwb3J0QDEgewo+ICsJCQlsdmRzMF9vdXQ6IGVuZHBvaW50IHsKPiArCQkJCXJl bW90ZS1lbmRwb2ludCA9IDwmdGhjNjNsdmQxMDI0X2luPjsKPiArCQkJfTsKPiArCQl9Owo+ICsJ fTsKPiArfTsKPiArCj4gICZlaGNpMCB7Cj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIH07CgoKLS0g ClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=