All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Michal Kubecek <mkubecek@suse.cz>
Cc: netdev@vger.kernel.org, Edwin Peer <edwin.peer@broadcom.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Andrew Gospodarek <andrew.gospodarek@broadcom.com>,
	Michael Chan <michael.chan@broadcom.com>
Subject: Re: [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO_LIST
Date: Sun, 17 Jan 2021 20:48:20 -0700	[thread overview]
Message-ID: <807bb557-6e0c-1567-026c-13becbaff9c2@gmail.com> (raw)
In-Reply-To: <20210116172119.2c68d4c2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On 1/16/21 6:21 PM, Jakub Kicinski wrote:
> 
> I wonder. There is something inherently risky about making
> a precedent for user space depending on invalid kernel output.
> 
> _If_ we want to fix the kernel, IMO we should only fix the kernel.
> 

IMHO this is a kernel bug that should be fixed. An easy fix to check the
overflow in nla_nest_end and return an error. Sadly, nla_nest_end return
code is ignored and backporting any change to fix that will be
nightmare. A warning will identify places that need to be fixed.

We can at least catch and fix this overflow which is by far the primary
known victim of the rollover.

  reply	other threads:[~2021-01-18  3:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 22:59 [PATCH iproute2] iplink: work around rtattr length limits for IFLA_VFINFO_LIST Edwin Peer
2021-01-15 23:53 ` Jakub Kicinski
2021-01-16 21:12   ` Michal Kubecek
2021-01-17  1:21     ` Jakub Kicinski
2021-01-18  3:48       ` David Ahern [this message]
2021-01-18 17:34         ` Edwin Peer
2021-01-18 17:36           ` David Ahern
2021-01-18 17:42             ` Edwin Peer
2021-01-18 17:49               ` David Ahern
2021-01-18 18:20                 ` Edwin Peer
2021-01-18 18:30                   ` Michal Kubecek
2021-01-18 17:31       ` Edwin Peer
2021-01-18 17:37     ` Edwin Peer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=807bb557-6e0c-1567-026c-13becbaff9c2@gmail.com \
    --to=dsahern@gmail.com \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=edwin.peer@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.